Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Re-enable rocksdb backend in build.yml #17474

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Aug 21, 2023

Description

Closes: #17437

  • pin nixpkgs to latest master

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Closes: cosmos#17437

- pin nixpkgs to latest master
@yihuang yihuang requested a review from a team as a code owner August 21, 2023 02:00
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mmsqe
Copy link
Contributor

mmsqe commented Aug 21, 2023

maybe can try add export GOPROXY=https://proxy.golang.org,direct

@yihuang yihuang marked this pull request as draft August 21, 2023 03:11
flake.nix Outdated Show resolved Hide resolved
@yihuang
Copy link
Collaborator Author

yihuang commented Aug 21, 2023

maybe can try add export GOPROXY=https://proxy.golang.org,direct

fixed in nixpkgs, but need to wait for it to merge.

@yihuang yihuang marked this pull request as ready for review August 21, 2023 06:30
@julienrbrt julienrbrt added this pull request to the merge queue Aug 21, 2023
Merged via the queue into cosmos:main with commit c94ce04 Aug 21, 2023
40 of 42 checks passed
@yihuang yihuang deleted the update-go branch August 21, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable Build with rocksdb backend in build.yml
4 participants