refactor(distribution)!: use collections for DelegatorStartingInfo state #16483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 9, 2023 12:36
github-actions
bot
added
C:Simulations
C:x/distribution
testinginprod
changed the title
…starting_info' into tip/distribution/coll_delegator_starting_info
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
alexanderbez
approved these changes
Jun 9, 2023
tac0turtle
reviewed
Jun 9, 2023
| ) | ||
| err = k.DelegatorStartingInfo.Walk(ctx, nil, func(key collections.Pair[sdk.ValAddress, sdk.AccAddress], value types.DelegatorStartingInfo) (stop bool, err error) { | ||
| dels = append(dels, types.DelegatorStartingInfoRecord{ | ||
| DelegatorAddress: key.K2().String(), |
There was a problem hiding this comment.
we should open an issue to migrate state to not use bech32 addresses in state
There was a problem hiding this comment.
I can tackle it once an issue is opened ;-)
There was a problem hiding this comment.
we should verify how slow the migration would be and possibly to a lazy migration
tac0turtle
approved these changes
Jun 9, 2023
julienrbrt
approved these changes
Jun 10, 2023
| Height: suite.app.LastBlockHeight() + 1, | ||
| Hash: suite.app.LastCommitID().Hash, | ||
| }) | ||
| require.NoError(suite.T(), err) |
There was a problem hiding this comment.
nit, suite.Require().NoError(
added 3 commits
June 14, 2023 12:02
# Conflicts: # CHANGELOG.md
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16484
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change