refactor: abci++ integration #16109
Merged
refactor: abci++ integration #16109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Rosetta
tac0turtle
commented
May 11, 2023
Comment on lines
-120
to
-123
| // write the state writes to the underlying store and set the final commit. | ||
| // Commit should be called after initchain in order to commit changes to disk | ||
| app.finalizeBlockState.ms.Write() | ||
|
|
tac0turtle
commented
May 11, 2023
|
|
||
| // commit genesis changes | ||
| if !startupConfig.AtGenesis { | ||
| app.Commit(context.TODO(), &abci.RequestCommit{}) |
There was a problem hiding this comment.
i removed this on main and it all still worked, this was a noop
tac0turtle
commented
May 11, 2023
| @@ -38,7 +38,12 @@ func TestInitApp(t *testing.T) { | |||
| req := abci.RequestInitChain{ | |||
| AppStateBytes: appState, | |||
| } | |||
| app.InitChain(context.TODO(), &req) | |||
| res, err := app.InitChain(context.TODO(), &req) | |||
There was a problem hiding this comment.
in this test since we are querying state that is being written to disk then we need to call finalize to push it to disk for commit to flush it
alexanderbez
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref #12272
figured out the commit code was used as a hack to write state when it wasnt necessary. Went through comet abci flow and commit isnt called after init so there isnt a need for us to do it in testing.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change