feat: add local snapshots management commands (backport #16067) #16102
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Co-authored-by: Marko <[email protected]> (cherry picked from commit c1ceb3b) # Conflicts: # CHANGELOG.md # go.mod # server/types/app.go # simapp/simd/cmd/root.go # simapp/simd/cmd/root_v2.go # snapshots/store.go
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| path := args[0] | ||
| fp, err := os.Open(path) |
Check failure
Code scanning / gosec
Potential file inclusion via variable
| return err | ||
| } | ||
|
|
||
| fp, err := os.Create(output) |
Check failure
Code scanning / gosec
Potential file inclusion via variable
| if err != nil { | ||
| return err | ||
| } | ||
| defer fp.Close() |
Check failure
Code scanning / gosec
Deferring unsafe method "Close" on type "io.ReadCloser"
| // The hash of the chunk is appended to the snapshot's metadata, | ||
| // and the overall snapshot hash is updated with the chunk content too. | ||
| func (s *Store) saveChunk(chunkBody io.ReadCloser, index uint32, snapshot *types.Snapshot, chunkHasher, snapshotHasher hash.Hash) error { | ||
| defer chunkBody.Close() |
Check failure
Code scanning / gosec
Deferring unsafe method "Close" on type "io.ReadCloser"
| if err != nil { | ||
| return errors.Wrapf(err, "failed to create snapshot chunk file %q", path) | ||
| } | ||
| defer chunkFile.Close() |
Check failure
Code scanning / gosec
Deferring unsafe method "Close" on type "io.ReadCloser"
| go func() { | ||
| defer close(quitChan) | ||
|
|
||
| savedSnapshot, err := snapshotStore.Save(snapshot.Height, snapshot.Format, chunks) | ||
| if err != nil { | ||
| fmt.Println("failed to save snapshot", err) | ||
| return | ||
| } | ||
| quitChan <- savedSnapshot | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine
| "fmt" | ||
| "io" | ||
| "os" | ||
| "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import
|
|
||
| for i := uint32(0); i < snapshot.Chunks; i++ { | ||
| path := snapshotStore.PathChunk(height, uint32(format), i) | ||
| file, err := os.Open(path) |
Check failure
Code scanning / gosec
Potential file inclusion via variable
| if err != nil { | ||
| return fmt.Errorf("failed to open chunk file %s: %w", path, err) | ||
| } | ||
| defer file.Close() |
Check failure
Code scanning / gosec
Deferring unsafe method "Close" on type "io.ReadCloser"
| defer chunkBody.Close() | ||
|
|
||
| path := s.PathChunk(snapshot.Height, snapshot.Format, index) | ||
| chunkFile, err := os.Create(path) |
Check failure
Code scanning / gosec
Potential file inclusion via variable
|
@yihuang can we improve the restore command (from main)? If we try loading a non-existing snapshot, it panics with a nil pointer. |
sure |
…cosmos#16102) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…cosmos#16102) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]>
This is an automatic backport of pull request #16067 done by Mergify.
Cherry-pick of c1ceb3b has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com