chore(ABCI++): update/fix testutil tests #16088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
force-pushed
the
bez/abci++_testutil_updates
branch
from
99d0696
to
a462707
Compare
alexanderbez
requested review from
mark-rushakoff and
tac0turtle
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| app.logger.Info("Running end block", "height", height) | ||
| app.EndBlock(cmtabcitypes.RequestEndBlock{}) | ||
| app.logger.Info("Running EndBlock", "height", height) | ||
| app.moduleManager.EndBlock(ctx) |
Check warning
Code scanning / gosec
Errors unhandled.
| ctx := app.ctx.WithBlockHeight(height).WithChainID(appName) | ||
|
|
||
| app.logger.Info("Running BeginBlock", "height", height) | ||
| app.moduleManager.BeginBlock(ctx) |
Check warning
Code scanning / gosec
Errors unhandled.
tac0turtle
reviewed
May 10, 2023
| switchCh <- n.PEXReactor().Switch | ||
| // Notify that the new node's switch is available, so this node can be | ||
| // peered with the other nodes. | ||
| switchCh <- n.Switch() |
There was a problem hiding this comment.
made me laugh, one api is private but a lower layer is still public
tac0turtle
approved these changes
May 10, 2023
|
@tac0turtle is this the PR that broke liveness tests for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #12272
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change