Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update ValidateVoteExtensions #16022

Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented May 3, 2023

Description

Update ValidateVoteExtensions to ensure at least 2/3 validators, by voting power, have submitted valid vote extensions as specified by the SDK ABCI++ ADR.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez marked this pull request as ready for review May 3, 2023 19:40
@alexanderbez alexanderbez requested a review from a team as a code owner May 3, 2023 19:40
// VoteExtensionThreshold defines the total voting power % that must be
// submitted in order for all vote extensions to be considered valid for a
// given height.
var VoteExtensionThreshold = math.LegacyNewDecWithPrec(667, 3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something that came to me while reading this was what if an application says only these 5 validators need to do this vote extension and these other 10 have to do some other work, would that make sense to try or does that defeat the purpose a little?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they'd wanna do something like that, then I would argue they should implement their own ValidateVoteExtensions function. Recall, ValidateVoteExtensions is just a helper function we provide for apps. They're not forced to use it. They can also use it as a reference too if they wish.

@alexanderbez alexanderbez merged commit 5a70b20 into bez/feature/abci-2.0-base May 4, 2023
@alexanderbez alexanderbez deleted the bez/abci-update-vote-ext-verification branch May 4, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants