Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codec)!: add get signers to codec + merged proto registry to InterfaceRegistry #15600

Merged
merged 11 commits into from
Mar 31, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Mar 29, 2023

Description

Ref: #11275

This PR pulls the codec changes from #15284 into a smaller PR.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Mar 29, 2023
@aaronc aaronc changed the title feat(codec)!: add support for get signers to codec + merged proto reg… feat(codec)!: add get signers to codec + merged proto registry to InterfaceRegistry Mar 29, 2023
@aaronc aaronc marked this pull request as ready for review March 29, 2023 15:31
@aaronc aaronc requested a review from a team as a code owner March 29, 2023 15:31
codec/codec.go Outdated Show resolved Hide resolved
codec/amino_codec.go Outdated Show resolved Hide resolved
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK,

@kocubinski kocubinski self-assigned this Mar 30, 2023
@tac0turtle tac0turtle self-assigned this Mar 30, 2023
Copy link
Member

@kocubinski kocubinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit.

@aaronc aaronc enabled auto-merge (squash) March 30, 2023 19:44
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 31, 2023
@aaronc aaronc merged commit 9332942 into main Mar 31, 2023
@aaronc aaronc deleted the aaronc/11275-codec-changes branch March 31, 2023 14:36
)

// AminoCodec defines a codec that utilizes Codec for both binary and JSON
// encoding.
// Deprecated: AminoCodec defines a codec that utilizes Codec for both binary and JSON
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its unclear how this is deprecated without supporting JSONcodec, is there a way you envision to manage this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants