fix: flaky group genesis sim #15447

robert-zaremba · 2023-03-17T16:04:42Z

Description

There are two conditions which may make the group sim test to fail:

The gov genesis sims assumes we have at least 3 accounts: https://github.com/cosmos/cosmos-sdk/blob/robert%2Fflaky-gov-sim/x/group/simulation/genesis.go#L135
duplicated member in getGroupMembers.

PS: I am considering to change the numKeys param to generate sim data accounts from 2 to 3, make it more robust. What do you think?

julienrbrt · 2023-03-17T16:07:26Z

I think you mean group right? Which failure were you getting, btw?
I haven't tested your fix, but when I hear flaky group sims, I think of #14833 (but your fix looks unrelated).

robert-zaremba · 2023-03-17T21:33:26Z

Yes, group. Updating the title and description.

julienrbrt

utACK

(cherry picked from commit f4a6feb)

Co-authored-by: Robert Zaremba <[email protected]>

* fix: create snapshot dir for rocksdb backend (backport cosmos#15054) (cosmos#15065) Co-authored-by: yihuang <[email protected]> * chore: Add check for uneven stores' height (backport cosmos#14410) (cosmos#15115) Co-authored-by: khanh-notional <[email protected]> Co-authored-by: marbar3778 <[email protected]> * refactor!: remove store v2alpha1 (cosmos#15152) * build: use cometbft in v0.46 (cosmos#15090) * chore: bump cometbft to v0.34.27 final (cosmos#15206) * fix: Change proposer address cast for `sdk_block` conversion (backport cosmos#15243) (cosmos#15245) Co-authored-by: Maksym Hontar <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: revert double close fix (cosmos#15255) * chore: prepare v0.46.11 release (cosmos#15259) * feat: add extend cb to avoid unmarshal state twice for sim test (backport: cosmos#15305) (cosmos#15321) * feat: add extend cb with genesisState for sim test (backport: cosmos#15305) (cosmos#15349) * fix: add extra check in vesting (backport cosmos#15373) (cosmos#15383) Co-authored-by: Julien Robert <[email protected]> * docs: update cosmwasm link (cosmos#15441) * fix: remove extra `;` in service.proto (cosmos#15443) * fix: flaky group genesis sim (backport cosmos#15447) (cosmos#15461) Co-authored-by: Robert Zaremba <[email protected]> * feat: add delegator to withdraw address (backport cosmos#15462) (cosmos#15473) Co-authored-by: Marko <[email protected]> * docs: improve proto vesting docs about time attributes (backport cosmos#15474) (cosmos#15481) Co-authored-by: Julien Robert <[email protected]> * feat: add query `groups` in `x/group` (backport cosmos#14879) (cosmos#15476) Co-authored-by: atheeshp <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: Makefile rocksdb (backport cosmos#15422) (cosmos#15525) Co-authored-by: Robert Zaremba <[email protected]> * fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667) Co-authored-by: Daniel Wedul <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> * fix: remove unnecessary cms typecasting (backport cosmos#14054) (cosmos#15669) Co-authored-by: Javier Su <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.46.12 release notes (cosmos#15685) * fix: upstream error on empty version (backport cosmos#13355) (cosmos#15717) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: More flexibility for `CacheMultiStoreWithVersion` (backport cosmos#15683) (cosmos#15775) Co-authored-by: khanh-notional <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: add moduleStateCb to allow access moduleState in sim test (backport cosmos#15903) (cosmos#15925) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): bump cometbft to v0.34.28 (cosmos#15973) * chore(gov): improve proposal conversion error message (backport cosmos#15979) (cosmos#15981) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * feat!: bootstrap comet cmd for local state sync (backport cosmos#16061) (cosmos#16080) Co-authored-by: Marko <[email protected]> * chore(auth/vesting): fix typo in `create-period-vesting-account` cmd example (backport cosmos#16085) (cosmos#16087) Co-authored-by: Julien Robert <[email protected]> * feat: add local snapshots management commands (backport cosmos#16067) (cosmos#16103) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: snapshot commands panic if snapshot don't exists (backport cosmos#16138) (cosmos#16140) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: add Close method for resource cleanup in graceful shutdown (backport cosmos#16193) (cosmos#16205) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: save restored snapshot locally (backport cosmos#16060) (cosmos#16262) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]> * chore: update sidebar v0.46 (cosmos#16304) * chore: add baseapp circuit breaker setter (cosmos#16289) Co-authored-by: Julien Robert <[email protected]> * fix: allow any address in `ValidatePromptAddress` (backport cosmos#16312) (cosmos#16314) Co-authored-by: Julien Robert <[email protected]> * feat(group): add group event tally result (backport cosmos#16191) (cosmos#16306) Co-authored-by: Jeancarlo Barrios <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: Revert "fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" (cosmos#16331) * chore: prepare v0.46.13 (cosmos#16249) * chore: small snapshot commands & docs improvement (backport cosmos#16404) (cosmos#16409) Co-authored-by: Julien Robert <[email protected]> * Add the quarantine and sanction stores to the import-export sim test. * refactor: avoid breaking change due to cosmos#16415 included in v0.50 (backport cosmos#16430) (cosmos#16432) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Facundo Medica <[email protected]> * chore: prepare v0.46.13 (2/2) (cosmos#16443) * fix: patch barberry (cosmos#16466) * Better gov prop error handling. * Fix the group sims random genesis so it can't pick the same account twice for the group policies since that address is the primary key for the table. Also, output the genesis state after it's randomized just like all the other modules do. * Add changelog entries. * Regen the swagger docs. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: yihuang <[email protected]> Co-authored-by: khanh-notional <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Maksym Hontar <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: atheeshp <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Javier Su <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: Jeancarlo Barrios <[email protected]> Co-authored-by: Facundo Medica <[email protected]>

* fix: create snapshot dir for rocksdb backend (backport cosmos#15054) (cosmos#15065) * chore: Add check for uneven stores' height (backport cosmos#14410) (cosmos#15115) * refactor!: remove store v2alpha1 (cosmos#15152) * build: use cometbft in v0.46 (cosmos#15090) * chore: bump cometbft to v0.34.27 final (cosmos#15206) * fix: Change proposer address cast for `sdk_block` conversion (backport cosmos#15243) (cosmos#15245) * fix: revert double close fix (cosmos#15255) * chore: prepare v0.46.11 release (cosmos#15259) * feat: add extend cb to avoid unmarshal state twice for sim test (backport: cosmos#15305) (cosmos#15321) * feat: add extend cb with genesisState for sim test (backport: cosmos#15305) (cosmos#15349) * fix: add extra check in vesting (backport cosmos#15373) (cosmos#15383) * docs: update cosmwasm link (cosmos#15441) * fix: remove extra `;` in service.proto (cosmos#15443) * fix: flaky group genesis sim (backport cosmos#15447) (cosmos#15461) * feat: add delegator to withdraw address (backport cosmos#15462) (cosmos#15473) * docs: improve proto vesting docs about time attributes (backport cosmos#15474) (cosmos#15481) * feat: add query `groups` in `x/group` (backport cosmos#14879) (cosmos#15476) * fix: Makefile rocksdb (backport cosmos#15422) (cosmos#15525) * fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667) * fix: remove unnecessary cms typecasting (backport cosmos#14054) (cosmos#15669) * chore: prepare v0.46.12 release notes (cosmos#15685) * fix: upstream error on empty version (backport cosmos#13355) (cosmos#15717) * feat: More flexibility for `CacheMultiStoreWithVersion` (backport cosmos#15683) (cosmos#15775) * feat: add moduleStateCb to allow access moduleState in sim test (backport cosmos#15903) (cosmos#15925) * build(deps): bump cometbft to v0.34.28 (cosmos#15973) * chore(gov): improve proposal conversion error message (backport cosmos#15979) (cosmos#15981) * feat!: bootstrap comet cmd for local state sync (backport cosmos#16061) (cosmos#16080) * chore(auth/vesting): fix typo in `create-period-vesting-account` cmd example (backport cosmos#16085) (cosmos#16087) * feat: add local snapshots management commands (backport cosmos#16067) (cosmos#16103) * fix: snapshot commands panic if snapshot don't exists (backport cosmos#16138) (cosmos#16140) * feat: add Close method for resource cleanup in graceful shutdown (backport cosmos#16193) (cosmos#16205) * feat: save restored snapshot locally (backport cosmos#16060) (cosmos#16262) * chore: update sidebar v0.46 (cosmos#16304) * chore: add baseapp circuit breaker setter (cosmos#16289) * fix: allow any address in `ValidatePromptAddress` (backport cosmos#16312) (cosmos#16314) * feat(group): add group event tally result (backport cosmos#16191) (cosmos#16306) * fix: Revert "fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" (cosmos#16331) * chore: prepare v0.46.13 (cosmos#16249) * chore: small snapshot commands & docs improvement (backport cosmos#16404) (cosmos#16409) * Add the quarantine and sanction stores to the import-export sim test. * refactor: avoid breaking change due to cosmos#16415 included in v0.50 (backport cosmos#16430) (cosmos#16432) * chore: prepare v0.46.13 (2/2) (cosmos#16443) * fix: patch barberry (cosmos#16466) * Better gov prop error handling. * Fix the group sims random genesis so it can't pick the same account twice for the group policies since that address is the primary key for the table. Also, output the genesis state after it's randomized just like all the other modules do. * Add changelog entries. * Regen the swagger docs. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: yihuang <[email protected]> Co-authored-by: khanh-notional <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Maksym Hontar <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: atheeshp <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Javier Su <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: Jeancarlo Barrios <[email protected]> Co-authored-by: Facundo Medica <[email protected]>

fix: flaky gov genesis sim

2ecb521

robert-zaremba added T: Tests C:Simulations backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release labels Mar 17, 2023

robert-zaremba requested a review from a team as a code owner March 17, 2023 16:04

github-actions bot added the C:x/group label Mar 17, 2023

robert-zaremba changed the title ~~fix: flaky gov genesis sim~~ fix: flaky group genesis sim Mar 17, 2023

julienrbrt approved these changes Mar 18, 2023

View reviewed changes

Merge branch 'main' into robert/flaky-gov-sim

c0203df

tac0turtle approved these changes Mar 20, 2023

View reviewed changes

Merge branch 'main' into robert/flaky-gov-sim

a88ef98

tac0turtle enabled auto-merge (squash) March 20, 2023 07:38

Merge branch 'main' into robert/flaky-gov-sim

d4581ea

tac0turtle merged commit f4a6feb into main Mar 20, 2023

tac0turtle deleted the robert/flaky-gov-sim branch March 20, 2023 10:34

This was referenced Mar 20, 2023

fix: flaky group genesis sim (backport #15447) #15460

Merged

fix: flaky group genesis sim (backport #15447) #15461

Merged

mergify bot pushed a commit that referenced this pull request Mar 20, 2023

fix: flaky group genesis sim (#15447)

3dd740a

(cherry picked from commit f4a6feb)

mergify bot pushed a commit that referenced this pull request Mar 20, 2023

fix: flaky group genesis sim (#15447)

cf2ce04

(cherry picked from commit f4a6feb)

julienrbrt pushed a commit that referenced this pull request Mar 20, 2023

fix: flaky group genesis sim (backport #15447) (#15460)

146d4e2

Co-authored-by: Robert Zaremba <[email protected]>

julienrbrt pushed a commit that referenced this pull request Mar 20, 2023

fix: flaky group genesis sim (backport #15447) (#15461)

8726f42

Co-authored-by: Robert Zaremba <[email protected]>

faddat mentioned this pull request Mar 28, 2023

update linter to 1521 ChihuahuaChain/cosmos-sdk#6

Closed

19 tasks

faddat mentioned this pull request Jun 8, 2023

barberry realiotech/cosmos-sdk#30

Merged

0xstepit mentioned this pull request Jul 1, 2024

chore(cachemulti): add Copy method evmos/cosmos-sdk#52

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: flaky group genesis sim #15447

fix: flaky group genesis sim #15447

robert-zaremba commented Mar 17, 2023 •

edited

Loading

julienrbrt commented Mar 17, 2023 •

edited

Loading

robert-zaremba commented Mar 17, 2023

julienrbrt left a comment

fix: flaky group genesis sim #15447

fix: flaky group genesis sim #15447

Conversation

robert-zaremba commented Mar 17, 2023 • edited Loading

Description

julienrbrt commented Mar 17, 2023 • edited Loading

robert-zaremba commented Mar 17, 2023

julienrbrt left a comment

Choose a reason for hiding this comment

robert-zaremba commented Mar 17, 2023 •

edited

Loading

julienrbrt commented Mar 17, 2023 •

edited

Loading