Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix validator cliff logic #1530

Closed
wants to merge 1 commit into from
Closed

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jul 3, 2018

Demonstrative testcase.

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated Gaia/Examples
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)

@cwgoes cwgoes added the wip label Jul 3, 2018
@cwgoes cwgoes requested a review from ebuchman as a code owner July 3, 2018 22:09
@cwgoes cwgoes changed the base branch from unstable to develop July 4, 2018 19:24
@rigelrozanski rigelrozanski mentioned this pull request Jul 6, 2018
7 tasks
@rigelrozanski
Copy link
Contributor

closing in favour of #1565

@rigelrozanski rigelrozanski deleted the cwgoes/a-validator-on-a-cliff branch July 6, 2018 00:25
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
* add ica proto

* add ica module

* fix: ica keeper

* add third party proto files

* bump ibc-go

* bump: go to 1.8

* integrating: icahost, intertx, fix keeper_test.go

* fix: lint

* formatting

* refactor:intertx -> icamauth

* fix: icacontroller err

* fix: lint

* fix: grpc

* update with interchain-account-demo

* fix: lint

* fix: dead link

* docs: update icamauth readme

* chore: update endpoint url

* refactor: move icamauth proto file to proto/gaia/icamauth/v1beta1

* remove: handleMsgData, controller does not check tx err on host side

* fix: lint

* fix: lint

* add: unit tests

* update go.work.sum

* update: icamauth module

* remove keeper and msg_server tests (temporary)

* Update x/icamauth/README.md

Co-authored-by: lg <[email protected]>

* update: app.go

* chore: clean comments

* test: add back unit test in icamauth

Co-authored-by: billy rennekamp <[email protected]>
Co-authored-by: lg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants