Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: x/upgrade to standalone module #14764

Merged
merged 22 commits into from
Jan 27, 2023
Merged

refactor: x/upgrade to standalone module #14764

merged 22 commits into from
Jan 27, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #14560

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 mentioned this pull request Jan 25, 2023
Merged
@likhita-809 likhita-809 marked this pull request as ready for review January 25, 2023 10:40
@likhita-809 likhita-809 requested a review from a team as a code owner January 25, 2023 10:40
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 25, 2023
View reviewed changes
x/upgrade/internal/conv/string.go
func UnsafeStrToBytes(s string) []byte {
var buf []byte
sHdr := (*reflect.StringHeader)(unsafe.Pointer(&s))
bufHdr := (*reflect.SliceHeader)(unsafe.Pointer(&buf))

Check warning

Code scanning / gosec

Use of unsafe calls should be audited

Use of unsafe calls should be audited
x/upgrade/internal/conv/string.go
// must not be altered after this function is called as it will cause a segmentation fault.
func UnsafeStrToBytes(s string) []byte {
var buf []byte
sHdr := (*reflect.StringHeader)(unsafe.Pointer(&s))

Check warning

Code scanning / gosec

Use of unsafe calls should be audited

Use of unsafe calls should be audited
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

[Cosmos SDK - x/upgrade] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

julienrbrt
julienrbrt reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except cosmovisor changes should be reverted.

go.mod Outdated Show resolved Hide resolved
tools/cosmovisor/go.mod Outdated Show resolved Hide resolved
julienrbrt
julienrbrt reviewed Jan 27, 2023
View reviewed changes
tools/cosmovisor/go.mod Outdated Show resolved Hide resolved
likhita-809
likhita-809 commented Jan 27, 2023
View reviewed changes
tools/cosmovisor/args.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!, pending tests fix.

atheeshp
atheeshp approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

CHANGELOG.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@github-actions github-actions bot removed the C:Cosmovisor Issues and PR related to Cosmovisor label Jan 27, 2023
@julienrbrt julienrbrt merged commit 6cf07f8 into main Jan 27, 2023
@julienrbrt julienrbrt deleted the likhita/upgrade-go-mod branch January 27, 2023 14:08
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
@likhita-809 @tsenart
refactor: x/upgrade to standalone module (cosmos#14764)
7c1812e
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@likhita-809
refactor: x/upgrade to standalone module (cosmos#14764)
6fd3915
@coderabbitai coderabbitai bot mentioned this pull request Apr 22, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@atheeshp atheeshp atheeshp approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@testinginprod testinginprod Awaiting requested review from testinginprod

Assignees

@atheeshp atheeshp

Labels
C:CLI C:x/evidence C:x/feegrant C:x/gov C:x/nft C:x/upgrade Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: x/upgrade as a standalone go module
3 participants
@likhita-809 @julienrbrt @atheeshp