fix: make linting work on 45

[faddat]

Description

in the 45 series sdk, we didn't check out the repository before running the linter, so it always passes

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[faddat]

so, now it is actually trying to run the linter

[faddat]

basically, if we don't mind, then no problem.

But 45's probably never had a run of the linter in ci.

[faddat]

ok, so, I'll walk through the PR-- and BTW, if we don't care about this, it is OK.

But to make a long story short, linting in 45 passed previously, not becuase of a defined version of the linter, but instead because we did not check the repo out in lint.yml

so it would always be "no changes here" and we would get a green tick, wheather or not linting passed, because linting didn't run.

NB: after some number of issues, the linter stops listing them. The CI likely shows an incomplete list of issues.

https://github.com/cosmos/cosmos-sdk/runs/8237391169?check_suite_focus=true

[tac0turtle]

okay lets fix it. sorry about the nitting

[faddat]

Oh no it's not a problem at all

The fact is unfortunately you're correct, I have the same concern about this

What I'll do is I'll write this today and then let's kind of see what happens next

[faddat]

Think this & the one on 46 are set.

[alexanderbez]

Thanks for all the hard work @faddat 🙏