Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollback command don't actually delete multistore versions (backport #11361) #13133

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 2, 2022

  • rollback command don't actually delete multistore versions

Closes: #11333

  • add unit tests
  • use LoadVersionForOverwriting
  • update tendermint dependency to 0.35.x release branch

Co-authored-by: Aleksandr Bezobchuk [email protected]

flushMetadata after rollback

Update server/rollback.go

Co-authored-by: Aleksandr Bezobchuk [email protected]

fix build

gofumpt

  • fix unit test

(cherry picked from commit 51d2de5)

  • fix unit test

  • changelog

  • api breaking changelog

Co-authored-by: yihuang [email protected]

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

…port cosmos#11361) (cosmos#13089)

* fix: rollback command don't actually delete multistore versions (cosmos#11361)

* rollback command don't actually delete multistore versions

Closes: cosmos#11333

- add unit tests
- use LoadVersionForOverwriting
- update tendermint dependency to 0.35.x release branch

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

flushMetadata after rollback

Update server/rollback.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

fix build

gofumpt

* fix unit test

(cherry picked from commit 51d2de5)

* fix unit test

* changelog

* api breaking changelog

Co-authored-by: yihuang <[email protected]>
@yihuang yihuang changed the title fix: rollback command don't actually delete multistore versions (back… fix: rollback command don't actually delete multistore versions (backport #11361) Sep 2, 2022
@alexanderbez
Copy link
Contributor

Looks like there is a build failure @yihuang

@yihuang
Copy link
Collaborator Author

yihuang commented Sep 5, 2022

Looks like there is a build failure @yihuang

fixed.

@tac0turtle tac0turtle merged commit bc28298 into cosmos:release/v0.45.x Sep 5, 2022
@yihuang yihuang deleted the backport-rollback branch September 5, 2022 07:17
Copy link

@AlphaMale1st AlphaMale1st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants