fix: decrease minimums for genesis parameters

[shaspitz]

For use in cosmos/interchain-security#313 to speed up integration tests

[mergify]

⚠️ The sha of the head commit of this PR conflicts with #12830. Mergify cannot evaluate rules on this PR. ⚠️

[tac0turtle]

You should be able to do this without modifying code. Using sed or wrapping the module would suffice

[alexanderbez]

Mhhh I don't want to change genesis validation just to make tests pass. I think there are other ways to tweak this in tests.

[shaspitz]

This isn't a matter of tests passing or failing, it'd just speed up ICS integration tests. There are definitely alternatives to changing the hardcoded values within this PR, I'm just struggling to see the intuition behind the exact values that were chosen.

That being said, I'm happy to implement one of the alternatives mentioned. It seems there is importance to these constraint values

[alexanderbez]

We can't say what strong motivation initially existed, but to change I'd say we need sufficient reason to do so, apart from making tests faster 👍

[jtremback]

@jackzampolin wrote this code originally here 4b4a2b8

Jack, do you remember what the 1 minute minimum was? Can it be reduced?

[jtremback]

In the commit above, a bunch of validations were added at once, and they look to be "sensible defaults". I would be surprised if there was a specific protocol reason for any of them to checked (beyond making sure that SignedBlocksWindow is positive).

	maxEvidence := data.Params.MaxEvidenceAge
	if maxEvidence < 1*time.Minute {
		return fmt.Errorf("Max evidence age must be at least 1 minute, is %s", maxEvidence.String())
	}

	dblSignUnbond := data.Params.DoubleSignUnbondDuration
	if dblSignUnbond < 1*time.Minute {
		return fmt.Errorf("Double sign unblond duration must be at least 1 minute, is %s", dblSignUnbond.String())
	}

	downtimeUnbond := data.Params.DowntimeUnbondDuration
	if downtimeUnbond < 1*time.Minute {
		return fmt.Errorf("Downtime unblond duration must be at least 1 minute, is %s", downtimeUnbond.String())
	}

	signedWindow := data.Params.SignedBlocksWindow
	if signedWindow < 10 {
		return fmt.Errorf("Signed blocks window must be at least 10, is %d", signedWindow)
	}

[alexanderbez]

Mhhh I give in. This PR can be re-opened then -- sorry

[shaspitz]

No worries, sounds good 🙏

[jtremback]

thanks @alexanderbez ! I also confirmed with Jack that it should be ok to change