Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use mocks for x/authz testing #12799

Merged
merged 15 commits into from
Aug 10, 2022
Merged

refactor: Use mocks for x/authz testing #12799

merged 15 commits into from
Aug 10, 2022

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #12761


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #12799 (acfab96) into main (2bb48e8) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12799      +/-   ##
==========================================
- Coverage   56.25%   56.19%   -0.07%     
==========================================
  Files         644      644              
  Lines       54933    54933              
==========================================
- Hits        30902    30867      -35     
- Misses      21541    21575      +34     
- Partials     2490     2491       +1     
Impacted Files Coverage Δ
x/authz/keeper/migrations.go 0.00% <0.00%> (-50.00%) ⬇️
x/authz/module/module.go 17.50% <0.00%> (-35.00%) ⬇️
x/authz/keeper/keeper.go 68.72% <0.00%> (-2.32%) ⬇️
x/group/keeper/keeper.go 56.29% <0.00%> (+0.39%) ⬆️

@alexanderbez
Copy link
Contributor

great work @likhita-809!!!

@likhita-809 likhita-809 marked this pull request as ready for review August 4, 2022 14:02
@likhita-809 likhita-809 requested a review from a team as a code owner August 4, 2022 14:02
Copy link
Contributor

@JeancarloBarrios JeancarloBarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@anilcse
Copy link
Collaborator

anilcse commented Aug 9, 2022

Snapshot tests are failing

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 10, 2022
@tac0turtle
Copy link
Member

Snapshot tests are failing

related to go 1.19. Need to debug

@mergify mergify bot merged commit f7e46ae into main Aug 10, 2022
@mergify mergify bot deleted the likhita/authz-mocks branch August 10, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Simulations C:x/authz Type: Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rewrite x/authz/ tests to use mocks
5 participants