Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use buildjet 4vcpu, 16gb runners #12219

Closed
wants to merge 18 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jun 10, 2022

Description

Closes: #12217

This changes the runners that we use for the cosmos sdk to use:

buildjet-4vcpu-ubuntu-2004

changes should only change every:

runs-on: ubuntu-latest

to

runs-on: buildjet-4vcpu-ubuntu-2004

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner June 10, 2022 11:36
@faddat faddat changed the title use buildjet 4vcpu, 16gb runners feat: use buildjet 4vcpu, 16gb runners Jun 10, 2022
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets only use it where its needed

.github/workflows/lint-pr.yml Outdated Show resolved Hide resolved
.github/workflows/proto-docker.yml Outdated Show resolved Hide resolved
.github/workflows/proto-registry.yml Outdated Show resolved Hide resolved
.github/workflows/proto.yml Outdated Show resolved Hide resolved
.github/workflows/proto.yml Outdated Show resolved Hide resolved
.github/workflows/stale.yml Outdated Show resolved Hide resolved
.github/workflows/atlas.yml Outdated Show resolved Hide resolved
.github/workflows/atlas.yml Outdated Show resolved Hide resolved
.github/workflows/check-docs.yml Outdated Show resolved Hide resolved
.github/workflows/clean-artifacts.yml Outdated Show resolved Hide resolved
@faddat
Copy link
Contributor Author

faddat commented Jun 10, 2022

happily

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few more

.github/workflows/codeql-analysis.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-docs.yml Outdated Show resolved Hide resolved
.github/workflows/dependencies-review.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/labeler.yml Outdated Show resolved Hide resolved
.github/workflows/linkchecker.yml Outdated Show resolved Hide resolved
@faddat
Copy link
Contributor Author

faddat commented Jun 10, 2022

Hey, thanks so much to those who updated this branch. To make these updates easier, if you contribute routinely to the cosmos sdk, and want privileges on the notional labs fork, please send a twitter dm. Anyone contributing regularly is welcome.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Just a nit.

@@ -10,7 +10,7 @@ on:
jobs:
golangci:
name: golangci-lint
runs-on: ubuntu-latest
runs-on: buildjet-4vcpu-ubuntu-2004
Copy link
Member

@julienrbrt julienrbrt Jun 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: buildjet-4vcpu-ubuntu-2004
runs-on: ubuntu-latest

I don't think speeding-up this one is necessary either. It is running pretty fast too (cf https://github.com/cosmos/cosmos-sdk/actions/workflows/lint.yml)

@tac0turtle tac0turtle mentioned this pull request Jun 12, 2022
@tac0turtle
Copy link
Member

superseded by #12231

@tac0turtle tac0turtle closed this Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CI Faster
3 participants