Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement ABCI Query via gRPC #11642

Merged
merged 38 commits into from
Apr 25, 2022
Merged

feat: implement ABCI Query via gRPC #11642

merged 38 commits into from
Apr 25, 2022

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 14, 2022

Description

  • Add a new ABCIQuery gRPC query to the Tendermint gRPC Service
  • Update the queryServer to now accept a abciQueryFn that'll proxy the ABCI query request to the app
  • Minor cleanup

replaces: #11017
ref: #11012


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Apr 15, 2022
@alexanderbez alexanderbez marked this pull request as ready for review April 16, 2022 23:12
@alexanderbez alexanderbez marked this pull request as draft April 16, 2022 23:13
@alexanderbez
Copy link
Contributor Author

@colin-axner @charleenfei, could you let me know if this addresses/closes #7036 please?

@alexanderbez alexanderbez marked this pull request as ready for review April 17, 2022 16:04
@alexanderbez alexanderbez added C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. and removed C:CLI labels Apr 17, 2022
@tac0turtle
Copy link
Member

could you let me know if this addresses/closes #7036 please?

this is a short term fix, ideally we can add this natively into grpc headers, this way relayers can make normal requests and get headers instead of using this endpoint

@github-actions github-actions bot added the C:CLI label Apr 18, 2022
@alexanderbez
Copy link
Contributor Author

could you let me know if this addresses/closes #7036 please?

this is a short term fix, ideally we can add this natively into grpc headers, this way relayers can make normal requests and get headers instead of using this endpoint

Yeah there is an issue @aaronc created on that. We'll keep the issue open then but we should still get this in for IBC relayer UX.

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do people want this in v0.46? It's an API-breaking change, which requires changing your app.go, which I'd like to avoid

client/grpc/tmservice/service.go Show resolved Hide resolved
@alexanderbez
Copy link
Contributor Author

Do people want this in v0.46? It's an API-breaking change, which requires changing your app.go, which I'd like to avoid

Would be really nice. I think chains want this, as it's a "nice-to-have". But it is Go API breaking, so technically we should not do it.

@jackzampolin
Copy link
Member

I just want to pipe up in favor of including it in the 0.46 release. Its a significant improvement for clients and especially with IBC queries there are more usecases for this endpoint. We should def include this in the release with a small disclaimer.

@tac0turtle
Copy link
Member

I just want to pipe up in favor of including it in the 0.46 release. Its a significant improvement for clients and especially with IBC queries there are more usecases for this endpoint. We should def include this in the release with a small disclaimer.

we agreed to backport as well. We agreed that the feature is well worth it

@alexanderbez
Copy link
Contributor Author

Ok, I'm going to merge this and backport it then.

@alexanderbez alexanderbez added the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Apr 25, 2022
@alexanderbez alexanderbez merged commit 3daa660 into main Apr 25, 2022
@alexanderbez alexanderbez deleted the bez/grpc-abci-query branch April 25, 2022 21:54
mergify bot pushed a commit that referenced this pull request Apr 25, 2022
(cherry picked from commit 3daa660)

# Conflicts:
#	CHANGELOG.md
tac0turtle pushed a commit that referenced this pull request Apr 26, 2022
* feat: implement ABCI Query via gRPC (#11642)

(cherry picked from commit 3daa660)

# Conflicts:
#	CHANGELOG.md

* updates

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:CLI C: gRPC Issues and PRs related to the gRPC service and HTTP gateway.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants