-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add meeting list and working groups to contributing doc #10315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
A few suggestions on framing, but generally looks good to me.
@@ -1,72 +1,84 @@ | |||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a diff on this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New lines format changed. Open the "old" file (eg in release/v0.44) - you will see weird windows style new lines.
CONTRIBUTING.md
Outdated
@@ -44,6 +43,23 @@ not required to an open issue to submit a PR, but be aware that for more complex | |||
problems/features, if a PR is opened before an adequate design discussion has | |||
taken place in a GitHub issue, that PR runs a high likelihood of being rejected. | |||
|
|||
## Teams Dev Calls | |||
|
|||
The Cosmos SDK team is fully decentralized and self organized. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it seem like there's no clear decision making structure at all, or hierarchy of roles. I would suggest either removing this line, or reframing it to say something like "Regen Network Development operates as lead maintainers of the SDK, and welcome long-term contributors & additional maintainers from other projects. We use self-organizing principles to coordinate development work and collaborate across organizations in structured "Working Groups" that focus on specific problem domains or architectural components of the SDK".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is also worth just being clear that @aaronc is the SDK product owner.
Thanks for putting this together. I think it is a very good next step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi friends! Can we replace all instances of "the SDK" with
"the Cosmos SDK"
good work going on here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the section. Could you review again please?
Co-authored-by: Cory <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @clevinson's comment.
Looks good overall, some small nits.
Co-authored-by: Marie Gauthier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice addition, pre-approving
How about linking the QA Team document in CONTRIBUTING? |
Co-authored-by: Amaury <[email protected]> Co-authored-by: Marie Gauthier <[email protected]>
let get that in a following PR. Lets merge this for now |
Description
We were requested to add more details about the meetings and how we work.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change