Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add meeting list and working groups to contributing doc #10315

Merged
merged 8 commits into from
Oct 13, 2021

Conversation

robert-zaremba
Copy link
Collaborator

Description

We were requested to add more details about the meetings and how we work.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba added the T:Docs Changes and features related to documentation. label Oct 6, 2021
Copy link
Contributor

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

A few suggestions on framing, but generally looks good to me.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@@ -1,72 +1,84 @@
<!--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a diff on this file?

Copy link
Collaborator Author

@robert-zaremba robert-zaremba Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New lines format changed. Open the "old" file (eg in release/v0.44) - you will see weird windows style new lines.

CONTRIBUTING.md Outdated
@@ -44,6 +43,23 @@ not required to an open issue to submit a PR, but be aware that for more complex
problems/features, if a PR is opened before an adequate design discussion has
taken place in a GitHub issue, that PR runs a high likelihood of being rejected.

## Teams Dev Calls

The Cosmos SDK team is fully decentralized and self organized.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it seem like there's no clear decision making structure at all, or hierarchy of roles. I would suggest either removing this line, or reframing it to say something like "Regen Network Development operates as lead maintainers of the SDK, and welcome long-term contributors & additional maintainers from other projects. We use self-organizing principles to coordinate development work and collaborate across organizations in structured "Working Groups" that focus on specific problem domains or architectural components of the SDK".

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is also worth just being clear that @aaronc is the SDK product owner.
Thanks for putting this together. I think it is a very good next step.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi friends! Can we replace all instances of "the SDK" with
"the Cosmos SDK"

good work going on here!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the section. Could you review again please?

Copy link
Contributor

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @clevinson's comment.
Looks good overall, some small nits.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition, pre-approving

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@robert-zaremba
Copy link
Collaborator Author

How about linking the QA Team document in CONTRIBUTING?

Co-authored-by: Amaury <[email protected]>
Co-authored-by: Marie Gauthier <[email protected]>
README.md Show resolved Hide resolved
@tac0turtle
Copy link
Member

How about linking the QA Team document in CONTRIBUTING?

let get that in a following PR. Lets merge this for now

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 13, 2021
@mergify mergify bot merged commit 27bae80 into master Oct 13, 2021
@mergify mergify bot deleted the robert/contributing-meetings branch October 13, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants