Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: authz client spec #10136

Merged
merged 7 commits into from
Sep 17, 2021
Merged

docs: authz client spec #10136

merged 7 commits into from
Sep 17, 2021

Conversation

ryanchristo
Copy link
Contributor

@ryanchristo ryanchristo commented Sep 14, 2021

Description

Ref: #9707

  • Add client.md to module specification.
  • Add client.md page to authz module spec.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the documentation writing guidelines
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct docs: prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR only changes documentation
  • reviewed content for consistency
  • reviewed content for thoroughness
  • reviewed content for spelling and grammar
  • tested instructions (if applicable)

@@ -34,6 +34,7 @@ following list is nonbinding and all files are optional.
- `XX_end_block.md` - specify any end-block operations
- `XX_hooks.md` - describe available hooks to be called by/from this module
- `XX_events.md` - list and describe event tags used
- `XX_client.md` - list and describe CLI commands and gRPC endpoints
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

order: 5
-->

# Client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This is exactly how I'd order and structure it too.

@orijbot
Copy link

orijbot commented Sep 14, 2021

@ryanchristo ryanchristo marked this pull request as ready for review September 14, 2021 17:17
@ryanchristo ryanchristo requested a review from aaronc as a code owner September 14, 2021 17:17
@github-actions github-actions bot added the C:CLI label Sep 14, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #10136 (72df8b3) into master (22cd778) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10136      +/-   ##
==========================================
- Coverage   63.74%   63.71%   -0.03%     
==========================================
  Files         573      573              
  Lines       53655    53676      +21     
==========================================
- Hits        34203    34202       -1     
- Misses      17505    17527      +22     
  Partials     1947     1947              
Impacted Files Coverage Δ
server/rosetta/client_online.go 0.00% <0.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

x/authz/spec/05_client.md Show resolved Hide resolved
x/authz/spec/05_client.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/authz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants