Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction tips (aka "meta transactions") - proto definitions #9406

Closed
aaronc opened this issue May 27, 2021 · 5 comments · Fixed by #9405
Closed

Add transaction tips (aka "meta transactions") - proto definitions #9406

aaronc opened this issue May 27, 2021 · 5 comments · Fixed by #9405
Assignees
@aaronc @amaury1093
Labels
C:x/auth S:proposal accepted

Comments

@aaronc
Copy link
Member

aaronc commented May 27, 2021 •
edited by amaury1093
Loading

This is to support multi-denom fees along the lines of Ethereum meta-transactions. @gamarin2 can you share more details?

See #9912 for implementation
@aaronc aaronc mentioned this issue May 27, 2021
Merged
9 tasks
@aaronc aaronc added Status: Backlog S:needs architecture review To discuss on the next architecture review call to come to alignment and removed Status: Backlog labels May 28, 2021
@aaronc aaronc self-assigned this May 28, 2021
@aaronc aaronc changed the title Add support for transaction tips Add transaction tips (aka "meta transactions") Jun 2, 2021
@aaronc aaronc added this to the v0.44 milestone Jun 2, 2021
@clevinson clevinson mentioned this issue Jun 11, 2021
Closed
4 tasks
@clevinson clevinson added the Epic label Jun 21, 2021
@aaronc aaronc removed the Epic label Jun 21, 2021
@clevinson clevinson added S:proposal accepted and removed S:needs architecture review To discuss on the next architecture review call to come to alignment S:proposed labels Jun 25, 2021
@clevinson clevinson mentioned this issue Jun 25, 2021
Closed
4 tasks
@ruhatch
Copy link
Contributor

ruhatch commented Jul 12, 2021

@aaronc @clevinson @gamarin2 is there more context on this somewhere? I've talked it through with @clevinson and get the gist, but wondering if there are any design/architecture docs, requirements, or discussions around?

@aaronc
Copy link
Member Author

aaronc commented Jul 12, 2021

@ruhatch see #9405. Sorry it's not better documented.

@aaronc
Copy link
Member Author

aaronc commented Jul 23, 2021

This needs #9585 because we must only charge a tip if there was enough gas, so we need processing both before and after running msgs.

@aaronc aaronc mentioned this issue Jul 27, 2021
Closed
@blushi blushi assigned amaury1093 and unassigned ruhatch Jul 28, 2021
@clevinson clevinson mentioned this issue Aug 3, 2021
Closed
@clevinson clevinson changed the title Add transaction tips (aka "meta transactions") Add transaction tips (aka "meta transactions") - proto definitions Aug 6, 2021
@mergify mergify bot closed this as completed in #9405 Aug 11, 2021
mergify bot pushed a commit that referenced this issue Aug 11, 2021
@aaronc
feat: Add SIGN_MODE_DIRECT_AUX and tx Tip proto definitions (#9405)
69b4935 
closes: #9406 

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes
@amaury1093 amaury1093 mentioned this issue Aug 11, 2021
Closed
1 task
@amaury1093
Copy link
Contributor

This issue has been renamed to only deal with Proto definitions. The next step is to add a tx middleware, which is discussed in #9912.

@aaronc aaronc mentioned this issue Sep 24, 2021
Closed
6 tasks
This was referenced Sep 29, 2021
Closed
Closed
@jooddang
Copy link

jooddang commented May 6, 2022

how's it different from feegrant module? https://docs.cosmos.network/master/modules/feegrant/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronc aaronc

@amaury1093 amaury1093

Labels
C:x/auth S:proposal accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add SIGN_MODE_DIRECT_AUX and tx Tip proto definitions cosmos/cosmos-sdk
5 participants
@aaronc @clevinson @jooddang @amaury1093 @ruhatch