Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/supply: Implement Querier #4082

Closed
4 tasks
alessio opened this issue Apr 10, 2019 · 5 comments · Fixed by #4592
Closed
4 tasks

x/supply: Implement Querier #4082

alessio opened this issue Apr 10, 2019 · 5 comments · Fixed by #4592
Assignees
@fedekunze
Milestone
v0.36.0

Comments

@alessio
Copy link
Contributor

alessio commented Apr 10, 2019 •
edited by alexanderbez
Loading

Description

As A an SDK REST/CLI user
I Want to execute queries against the supply module
So That I can learn about the network's supply related information

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

These need to be routed under /bank.

@alessio
Copy link
Contributor Author

alessio commented Apr 10, 2019

@alexanderbez please see #3972 (comment) - cc'ing @rigelrozanski

@alexanderbez alexanderbez changed the title Query Network's Total Supply via REST client x/supply: Querier & Spec Docs Jun 12, 2019
@alexanderbez alexanderbez changed the title x/supply: Querier & Spec Docs x/supply: Querier Jun 12, 2019
@alexanderbez alexanderbez mentioned this issue Jun 12, 2019
Closed
4 tasks
@alexanderbez alexanderbez added this to the v0.36.0 milestone Jun 12, 2019
@alexanderbez alexanderbez self-assigned this Jun 12, 2019
@alexanderbez alexanderbez changed the title x/supply: Querier x/supply: Implement Querier Jun 12, 2019
@rigelrozanski
Copy link
Contributor

Yeah I guess this makes sense to be under bank.

@alexanderbez
Copy link
Contributor

I don't think so anymore @rigelrozanski? We simply need a supply module querier.

@rigelrozanski
Copy link
Contributor

Sure I mean from a users perspective I could see it being fine under bank or supply - keeping it in supply would make it more true to the code, but organizationally introduce a bit more noise in the CLI - but I don't really have a preference

@fedekunze fedekunze assigned fedekunze and unassigned alexanderbez Jun 19, 2019
@fedekunze fedekunze mentioned this issue Jun 19, 2019
Merged
5 tasks
alessio pushed a commit that referenced this issue Jul 1, 2019
@fedekunze
supply querier (#4592)
48e8161 
Add querier to the supply module.

Closes: #4082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedekunze fedekunze

Labels
None yet
Projects
None yet
Milestone
v0.36.0
Development

Successfully merging a pull request may close this issue.

supply querier cosmos/cosmos-sdk
4 participants
@alessio @alexanderbez @rigelrozanski @fedekunze