Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make frequency of invariant checks configurable #4053

Closed
rigelrozanski opened this issue Apr 5, 2019 · 2 comments
Closed

Make frequency of invariant checks configurable #4053

rigelrozanski opened this issue Apr 5, 2019 · 2 comments
Assignees
Milestone

Comments

@rigelrozanski
Copy link
Contributor

rigelrozanski commented Apr 5, 2019

Description

REF #3914 (comment)

Rather than running the invariant checks every block, The node-operator should specify the number of blocks which they wish to run invariants with.

Additionally, each time the invariance is run, the number of block to run all invariants should be logged.

Acceptance Criteria

AC1

Given I run gaiad --inv-check-freq=N
Given N is strictly greater than 0
When the Nth block is created
Then invariance checks run
Then invariance checks output is logged.

AC2

Given I run gaiad --inv-check-freq=N
Given N equals 0
When the new blocks are created
Then invariance checks don't run

AC3

Given I run gaiad --inv-check-freq=N
Given N strictly smaller than 0
When the gaiad start
Then the node fails to start.

@rigelrozanski rigelrozanski added this to the v0.35.0 milestone Apr 5, 2019
@rigelrozanski rigelrozanski self-assigned this Apr 5, 2019
@alexanderbez
Copy link
Contributor

See my comment #3914 (comment). I think it should be configured blockly, not timely.

@rigelrozanski
Copy link
Contributor Author

sure, either sounds positive to me

@alessio alessio changed the title Run Invariant checks per timeperiod Make frequency of invariant checks configurable Apr 8, 2019
@alessio alessio self-assigned this Apr 10, 2019
@alexanderbez alexanderbez removed their assignment Apr 10, 2019
@alessio alessio reopened this Apr 11, 2019
@alessio alessio closed this as completed Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants