Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

locking implementation based Keybase implementation should be hidden #3592

Closed
4 tasks
alessio opened this issue Feb 11, 2019 · 1 comment
Closed
4 tasks

locking implementation based Keybase implementation should be hidden #3592

alessio opened this issue Feb 11, 2019 · 1 comment
Labels
S:proposed

Comments

@alessio
Copy link
Contributor

alessio commented Feb 11, 2019 •
edited
Loading

We should not export the New constructor of the crypto.Keybase old locking implementation-based dbKeybase. Most of the codebase has already been ported to LazyKeyBase, plus a NewInMemory constructor has already been made available to meet the in-memory keybase use case requirements.

cc @cosmos/cosmossdk

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alessio
Copy link
Contributor Author

alessio commented Feb 11, 2019

It'd be great to include this in the future v0.32.0 release.

alessio pushed a commit that referenced this issue Feb 11, 2019
hide dbKeybase's constructor
79a4aba 
crypto/keys.New(string, string) now returns a lazy keybase
instance. Function's signature has changed, this this is
an SDK Go API breaking change.

Remove client.MockKeyBase, superseded by
crypto/keys.NewInMemory()

Closes: #3592
@alessio alessio mentioned this issue Feb 11, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S:proposed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alessio @jackzampolin