Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCD is returning no RPC client defined on API calls on develop branch #2907

Closed
2 of 4 tasks
johnmcdowall opened this issue Nov 27, 2018 · 6 comments · Fixed by #2919
Closed
2 of 4 tasks

LCD is returning no RPC client defined on API calls on develop branch #2907

johnmcdowall opened this issue Nov 27, 2018 · 6 comments · Fixed by #2919
Labels
C:CLI T:Bug

Comments

@johnmcdowall
Copy link
Contributor

johnmcdowall commented Nov 27, 2018 •
edited by alexanderbez
Loading

Summary of Bug

It seems that LCD on develop has recently started giving no RPC client defined messages to API calls that work properly on master.

Steps to Reproduce

  1. Check out develop
  2. Build binaries
  3. Launch a local testnet with make localnet-start
  4. Launch LCD via a docker container with this command (make sure to use your chainid):
docker run -v `pwd`:`pwd` -w `pwd` -p 0.0.0.0:1317:1317 --network cosmos-sdk_localnet alpine build/gaiacli --home build/node0/gaiacli rest-server --trust-node=false --laddr tcp://0.0.0.0:1317 --node http://gaiadnode0:26657 --chain-id=chain-5t4HFT
  1. Hit the blocks latest LCD api: curl -k https://0.0.0.0:1317/blocks/latest
  2. See no RPC client defined message.
  3. Checkout master.
  4. Blow away build directory and recompile binaries
  5. Repeat above steps for launching testnet and LCD.
  6. Repeat LCD api query for latest block, see that it responds correctly.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jackzampolin
Copy link
Member

So I've spent some time looking into this. It looks like where we are setting the cliCtx for the RestServer is not properly pulling in configuration.

@alexanderbez
Copy link
Contributor

alexanderbez commented Nov 27, 2018 •
edited
Loading

@jackzampolin what configuration does it need? The command line arguments? Is this just an order of operations bug?

@jackzampolin
Copy link
Member

@alexanderbez I think so, was trying to debug last night but unsuccessful

@alexanderbez
Copy link
Contributor

Ok, I will look into it.

@alexanderbez alexanderbez mentioned this issue Nov 27, 2018
Merged
5 tasks
@alexanderbez
Copy link
Contributor

I cannot reproduce this after my fix in #2918.

@alexanderbez
Copy link
Contributor

In other words, the two are unrelated...sorry to burst the bubble here

@alexanderbez alexanderbez mentioned this issue Nov 27, 2018
Merged
5 tasks
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
@MSalopek
fix!: add missing consensus module registration; register gov hooks (c…
aae0c6c 
…osmos#2907)

* fix!: add missing consensus module registration; update hooks registration

* fix!: register params migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:CLI T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

R4R: Refactor Gaia Lite bootstrapping cosmos/cosmos-sdk
3 participants
@johnmcdowall @alexanderbez @jackzampolin