Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI JSON output is not encoded in JSON #2265

Closed
4 tasks done
alessio opened this issue Sep 7, 2018 · 4 comments
Closed
4 tasks done

CLI JSON output is not encoded in JSON #2265

alessio opened this issue Sep 7, 2018 · 4 comments
Assignees
@alessio
Labels
C:CLI good first issue T:Bug

Comments

@alessio
Copy link
Contributor

alessio commented Sep 7, 2018 •
edited
Loading

Summary of Bug

In

cosmos-sdk/client/context/query.go

Line 262 in 44b695c

resJSON := toJSON{res.Height, res.Hash.String(), fmt.Sprintf("%+v", res.DeliverTx)}
the Response field of the command's output is in string format. It should be encoded in JSON.

Steps to Reproduce

Just run gaiacli send --json <args> <params>.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alessio alessio mentioned this issue Sep 7, 2018
Merged
5 tasks
@alexanderbez
Copy link
Contributor

@melekes any updates on getting tags parsed in TM?

alessio pushed a commit that referenced this issue Sep 8, 2018
Fix CLI commands JSON output
3ceccfa 
When running with --json, commands should produce
correctly JSON-encoded output.

Closes: #2265
@alessio
Copy link
Contributor Author

alessio commented Sep 8, 2018

/cc @ebuchman @alexanderbez @cwgoes

@alessio alessio self-assigned this Sep 8, 2018
@melekes
Copy link
Contributor

melekes commented Sep 8, 2018

@alexanderbez I am sorry. Can I get a little more context?

@alexanderbez
Copy link
Contributor

Sorry @melekes no longer a concern 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
C:CLI good first issue T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alessio @melekes @alexanderbez