Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto - KeyBase.Update should check oldpass is correct before getting newpass #1629

Closed
UnitylChaos opened this issue Jul 11, 2018 · 0 comments
Closed

crypto - KeyBase.Update should check oldpass is correct before getting newpass #1629

UnitylChaos opened this issue Jul 11, 2018 · 0 comments
Assignees
@ValarDragon
Labels
C:Keys Keybase, KMS and HSMs T:Bug T: UX

Comments

@UnitylChaos
Copy link
Contributor

Currently gaiacli keys update *name* asks for the old password, then asks for the new password twice, and only checks that the old password is correct after all three lines have been input. Expected behavior would be that the command fails after the old password is entered if it is not correct.

cc @ValarDragon
@ValarDragon ValarDragon self-assigned this Jul 11, 2018
@ValarDragon ValarDragon mentioned this issue Jul 11, 2018
Merged
7 tasks
@ValarDragon ValarDragon added T:Bug T: UX C:Keys Keybase, KMS and HSMs labels Jul 11, 2018
ValarDragon added a commit that referenced this issue Jul 11, 2018
@ValarDragon
keys: Keybase.Update no longer asks for newpass if oldpass is incorrect
fc4c563 
Achieved by refactoring the parameter newpass as follows:

* (newpass string) -> (getNewpass func() (string, error))

Closes #1629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ValarDragon ValarDragon

Labels
C:Keys Keybase, KMS and HSMs T:Bug T: UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ValarDragon @UnitylChaos