Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

big.rat should not overflow in print statements #1258

Closed
rigelrozanski opened this issue Jun 14, 2018 · 0 comments
Closed

big.rat should not overflow in print statements #1258

rigelrozanski opened this issue Jun 14, 2018 · 0 comments
Labels
T:Bug

Comments

@rigelrozanski
Copy link
Contributor

overflows when the printing as int64
ValarDragon added a commit that referenced this issue Jun 26, 2018
@ValarDragon
types/rat: Fix overflowing in printing
a8de328 
This now uses the underlying golang big.rat's string function,
instead of casting to num and den which are int64s.

Closes #1258
@ValarDragon ValarDragon mentioned this issue Jun 26, 2018
Merged
6 tasks
cwgoes pushed a commit that referenced this issue Jun 26, 2018
@ValarDragon @cwgoes
Merge PR #1374: types/rat: Fix overflowing in printing
9f30a90 
This now uses the underlying golang big.rat's string function,
instead of casting to num and den which are int64s.

Closes #1258
adrianbrink pushed a commit that referenced this issue Jul 2, 2018
@ValarDragon
Merge PR #1374: types/rat: Fix overflowing in printing
503ba31 
This now uses the underlying golang big.rat's string function,
instead of casting to num and den which are int64s.

Closes #1258
cwgoes pushed a commit that referenced this issue Jul 2, 2018
@ValarDragon @cwgoes
Cherry-pick types/rat: Fix overflowing in printing
809f0e5 
This now uses the underlying golang big.rat's string function,
instead of casting to num and den which are int64s.

Closes #1258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ebuchman @rigelrozanski @cwgoes