Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor container Run to Build #11907

Closed
Tracked by #11899
aaronc opened this issue May 9, 2022 · 0 comments · Fixed by #11916
Closed
Tracked by #11899

Refactor container Run to Build #11907

aaronc opened this issue May 9, 2022 · 0 comments · Fixed by #11916
Assignees
Labels
C:depinject Issues and PR related to depinject

Comments

@aaronc
Copy link
Member

aaronc commented May 9, 2022

Currently container.Run takes a function with inputs but those inputs are usually used to set variables elsewhere, ex:

	var appBuilder *runtime.AppBuilder
        var cdc codec.Codec
	err := container.Run(func(b *runtime.AppBuilder, c codec.Codec) {
		appBuilder = b
                codec = c
	}, appConfig)
	if err != nil {
		return Config{}, err
	}

We shouldn't be running any code inside the container function anyway because that just makes error traces more confusing. A more correct and useful pattern would be:

       var appBuilder *runtime.AppBuilder
        var cdc codec.Codec
	err := container.Build(appConfig, &appBuilder, &codec)
	if err != nil {
		return Config{}, err
	}
@aaronc aaronc changed the title Switch container Run to Build Refactor container Run to Build May 9, 2022
@aaronc aaronc added the C:depinject Issues and PR related to depinject label May 9, 2022
@aaronc aaronc self-assigned this May 9, 2022
@mergify mergify bot closed this as completed in #11916 May 10, 2022
mergify bot pushed a commit that referenced this issue May 10, 2022
…ies (#11916)

## Description

Closes: #11907 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:depinject Issues and PR related to depinject
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants