Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add load tests to verify no race condition exists in app gRPC queries #10324

Closed
4 tasks done
robert-zaremba opened this issue Oct 7, 2021 · 2 comments · Fixed by #10371
Closed
4 tasks done

Add load tests to verify no race condition exists in app gRPC queries #10324

robert-zaremba opened this issue Oct 7, 2021 · 2 comments · Fixed by #10371
Assignees
@odeke-em @tac0turtle
Labels
C: comet

Comments

@robert-zaremba
Copy link
Collaborator

Summary

At the beginning of 2021 we found that there is a race condition when doing gRPC app queries. The quick solution was to route queries from app to tendermint. This was later fixed in tendermint and #10045 reverts that workaround.

To make sure there is no other trap, we need to make a load test with race detector to confirm that this works.

Goal:

  • create an automatic sim test with some data in a chain and bombard it with parallel queries
  • run test with race detector

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added this to the v0.45 milestone Oct 7, 2021
@robert-zaremba
Copy link
Collaborator Author

@marbar3778, today during the QA WG we were talking about testing queries. @odeke-em said that he could do it but he doesn't have much context. Could you confirm here if you can handle it or provide a support to @odeke-em if needed?

@robert-zaremba
Copy link
Collaborator Author

I think test with many queries in parallel will be enough to test the issue. Right?

@odeke-em odeke-em mentioned this issue Oct 14, 2021
Merged
@mergify mergify bot closed this as completed in #10371 Oct 16, 2021
mergify bot pushed a commit that referenced this issue Oct 16, 2021
@odeke-em
test: baseapp: add concurrent test for querying GRPCRouter (#10371)
c0cc052 
Runs 1,000 concurrent requests for baseapp.GRPCQueryRouter,
this test requires that we enable: go test -race.

Closes #10324
@amaury1093 amaury1093 mentioned this issue Oct 21, 2021
Merged
19 tasks
@robert-zaremba robert-zaremba mentioned this issue Oct 22, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odeke-em odeke-em

@tac0turtle tac0turtle

Labels
C: comet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: baseapp: add concurrent test for querying GRPCRouter
3 participants
@robert-zaremba @odeke-em @tac0turtle