Skip to content

Commit

Permalink
fix: rename back TxExtensionOptionI (#16145)
Browse files Browse the repository at this point in the history
  • Loading branch information
mmsqe authored May 15, 2023
1 parent 90e3e69 commit d818a62
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (types/coin) [#14739](https://github.com/cosmos/cosmos-sdk/pull/14739) Deprecate the method `Coin.IsEqual` in favour of `Coin.Equal`. The difference between the two methods is that the first one results in a panic when denoms are not equal. This panic lead to unexpected behavior
* (x/crypto) [#15258](https://github.com/cosmos/cosmos-sdk/pull/15258) Write keyhash file with permissions 0600 instead of 0555.
* (cli) [#16138](https://github.com/cosmos/cosmos-sdk/pull/16138) Fix snapshot commands panic if snapshot don't exists.
* (types) [#16145](https://github.com/cosmos/cosmos-sdk/pull/16145) Rename interface `ExtensionOptionI` back to `TxExtensionOptionI` to avoid breaking change.

### Deprecated

Expand Down
2 changes: 1 addition & 1 deletion testutil/testdata/codec.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func RegisterInterfaces(registry types.InterfaceRegistry) {
&HasHasAnimal{},
)
registry.RegisterImplementations(
(*tx.ExtensionOptionI)(nil),
(*tx.TxExtensionOptionI)(nil),
&Cat{},
)

Expand Down
4 changes: 2 additions & 2 deletions types/tx/ext.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ import (
)

// TxExtensionOptionI defines the interface for tx extension options
type ExtensionOptionI interface{}
type TxExtensionOptionI interface{} //nolint:revive // to avoid breaking change

// unpackTxExtensionOptionsI unpacks Any's to TxExtensionOptionI's.
func unpackTxExtensionOptionsI(unpacker types.AnyUnpacker, anys []*types.Any) error {
for _, any := range anys {
var opt ExtensionOptionI
var opt TxExtensionOptionI
err := unpacker.UnpackAny(any, &opt)
if err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion types/tx/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,5 +208,5 @@ func RegisterInterfaces(registry codectypes.InterfaceRegistry) {
registry.RegisterInterface("cosmos.tx.v1beta1.Tx", (*sdk.Tx)(nil))
registry.RegisterImplementations((*sdk.Tx)(nil), &Tx{})

registry.RegisterInterface("cosmos.tx.v1beta1.TxExtensionOptionI", (*ExtensionOptionI)(nil))
registry.RegisterInterface("cosmos.tx.v1beta1.TxExtensionOptionI", (*TxExtensionOptionI)(nil))
}

0 comments on commit d818a62

Please sign in to comment.