fix: snapshot commands panic if snapshot don't exists (backport #16138)…

… (#16140) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]>
cosmos · May 13, 2023 · 5472fb5 · 5472fb5
1 parent 10cc30f
commit 5472fb5
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/.gitignore b/.gitignore
@@ -23,6 +23,7 @@ dist
 tools-stamp
 buf-stamp
 artifacts
+tools/
 
 # Data - ideally these don't exist
 baseapp/data/*

diff --git a/client/snapshot/dump.go b/client/snapshot/dump.go
@@ -3,6 +3,7 @@ package snapshot
 import (
 	"archive/tar"
 	"compress/gzip"
+	"errors"
 	"fmt"
 	"io"
 	"os"
@@ -48,6 +49,10 @@ func DumpArchiveCmd() *cobra.Command {
 				return err
 			}
 
+			if snapshot == nil {
+				return errors.New("snapshot doesn't exist")
+			}
+
 			bz, err := snapshot.Marshal()
 			if err != nil {
 				return err

diff --git a/snapshots/manager.go b/snapshots/manager.go
@@ -398,6 +398,10 @@ func (m *Manager) RestoreLocalSnapshot(height uint64, format uint32) error {
 		return err
 	}
 
+	if snapshot == nil {
+		return fmt.Errorf("snapshot doesn't exist, height: %d, format: %d", height, format)
+	}
+
 	m.mtx.Lock()
 	defer m.mtx.Unlock()