-
Notifications
You must be signed in to change notification settings - Fork 404
adopt @scure/bip39 #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adopt @scure/bip39 #1843
Conversation
d9d68ef
to
6187f4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
"abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon art", | ||
), | ||
).toThrowError(/invalid word count(.*)got: 25/i); | ||
).toThrowError(/invalid/i); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the error test tests more specific here? "invalid" could be anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In testing, the full error message here wasn't actually any more specific, so in a literal sense we can't. It's just two words, 'Invalid mnemonic'
. Which could mean anything.
https://github.com/paulmillr/scure-bip39/blob/1.6.0/src/index.ts#L52
CJS package needed to work around node20 failing in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is there anything left before merging this?
Good to merge! |
Half of #1721
@scure/bip39
2.0 is an ESM package with dependencies, and Yarn 4'simport
loader hooks are compatible with node 22+, not node 20, so there's an error in the node 20 CI. Same trouble as at #1804