recommended-type-checked lints

[dynst]

As highlighted in the version 6 announcement, there's always been a separate config with more powerful type-aware lints like no-floating-promises.

https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/

Also enable import/recommended since apparently import/typescript isn't a superset of it.

[dynst]

There are a bunch of places where there's code like this

cosmjs/packages/faucet/src/actions/start.ts

Lines 42 to 45 in 553a0de

	setInterval(async () => {
	availableTokens = await faucet.availableTokens();
	console.info("Available tokens:", availableTokens);
	}, 60_000);

Which violates https://typescript-eslint.io/rules/no-misused-promises#checksvoidreturn since the async function returns a Promise that a function like setInterval or setTimeout is never going to await on or handle in any way. But I disabled the lint for now.

[webmaster128]

nice

[webmaster128]

We made them all "warn" for better IDE highlighting (which stoped working at some point). The lint CI then rejects all warnings anyways.

Suggested change

	"@typescript-eslint/consistent-type-exports": "error",
	"@typescript-eslint/consistent-type-exports": "warn",

[webmaster128]

What about ignoring them in-place? How many of those do we have?

[dynst]

For unit tests, there's a lot of boilerplate, and part of the boilerplate is passing async () => ... to the test framework, and it honestly seems very harmless to keep all that boilerplate the same even for tests that don't have an await call in them?

Outside of unit tests... yeah, there's a lot there too. A lot of asynchronous APIs. 15 warnings, but there will be more if you merge #1722

[webmaster128]

okay sounds good. Yeah no problem having a relaxed linter for test code.

[dynst]

It looks like there's another base-to-string here:

cosmjs/packages/crypto/src/slip10.ts

Line 226 in f4b51d7

: component.toString();

But I can't figure out why CI is passing but eslint finds this locally.

 226:9  error  'component' will use Object's default stringification format ('[object Object]') when stringified  @typescript-eslint/no-base-to-string

[dynst]

https://typescript-eslint.io/rules/no-unnecessary-type-assertion/

packages/amino/src/secp256k1hdwallet.ts
   98:12  error  This assertion is unnecessary since it does not change the type of the expression  @typescript-eslint/no-unnecessary-type-assertion
  178:14  error  This assertion is unnecessary since it does not change the type of the expression  @typescript-eslint/no-unnecessary-type-assertion
  237:55  error  This assertion is unnecessary since it does not change the type of the expression  @typescript-eslint/no-unnecessary-type-assertion
packages/cosmwasm-stargate/src/cosmwasmclient.spec.ts
  63:32  error  This assertion is unnecessary since the receiver accepts the original type of the expression  @typescript-eslint/no-unnecessary-type-assertion
packages/proto-signing/src/directsecp256k1hdwallet.ts
  105:12  error  This assertion is unnecessary since it does not change the type of the expression  @typescript-eslint/no-unnecessary-type-assertion
  177:14  error  This assertion is unnecessary since it does not change the type of the expression  @typescript-eslint/no-unnecessary-type-assertion
  235:55  error  This assertion is unnecessary since it does not change the type of the expression  @typescript-eslint/no-unnecessary-type-assertion
packages/stargate/src/modules/gov/aminomessages.ts
  208:44  error  This assertion is unnecessary since it does not change the type of the expression  @typescript-eslint/no-unnecessary-type-assertion
packages/stargate/src/stargateclient.spec.ts
  102:32  error  This assertion is unnecessary since the receiver accepts the original type of the expression  @typescript-eslint/no-unnecessary-type-assertion

But if you actually run eslint --fix for this lint, it breaks the build:

[@cosmjs/amino]: src/secp256k1hdwallet.ts:98:16 - error TS2339: Property 'type' does not exist on type 'object'.
[@cosmjs/amino]: 
[@cosmjs/amino]: 98   switch (root.type) {
[@cosmjs/amino]:                   ~~~~
[@cosmjs/amino]: 
[@cosmjs/amino]: src/secp256k1hdwallet.ts:178:18 - error TS2339: Property 'type' does not exist on type 'object'.
[@cosmjs/amino]: 
[@cosmjs/amino]: 178     switch (root.type) {
[@cosmjs/amino]:                      ~~~~
[@cosmjs/amino]: 
[@cosmjs/amino]: src/secp256k1hdwallet.ts:237:59 - error TS2339: Property 'kdf' does not exist on type 'object'.
[@cosmjs/amino]: 
[@cosmjs/amino]: 237     const encryptionKey = await executeKdf(password, root.kdf);
[@cosmjs/amino]:                                                               ~~~

Maybe this will be fixed when updating to version 8.0 of the plugin (which supports TypeScript 5.8.3).

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0

YOUR TYPESCRIPT VERSION: 5.8.3

Please only submit bug reports when using the officially supported version.

=============

[webmaster128]

: component.toString();

Here component is of type Slip10RawIndex which extends Uint32. So Uint32.toString is used at runtime. Maybe tooling does not get that?

[dynst]

Probably a local problem I have and that's why it passes on CI!

[webmaster128]

okay nice. Is this ready to merge?

[dynst]

Yep!