fix: update signAmino method to use messages directly
#1614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies the code by removing unnecessary mapping of messages.
|
The CI failures are not related to the changes in this PR. The CI is misconfigured and needs to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the code by removing unnecessary mapping of messages.
This PR also acts as a workaround for hyperweb-io/telescope#660 where
toAminoandfromAminoare not symmetrical.The ManifestJS and Manifest WebApp projects use this fix. Both projects can now properly sign AMINO transactions, including using Keplr and Ledger in-browser.
ManifestJS has a Starship test suite covering some use cases that fail without this fix.