feat: Add comprehensive chain metadata validation system #6505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Analysis Complete\! Enhanced GitHub workflows to automatically validate all chain metadata fields: ### Current Validation Status: **✅ Already Tested Fields:** 1. **Chain ID**: Validated in .github/workflows/utility/validate_data.mjs:64-78 - Checks uniqueness across registry 2. **Chain Name**: Validated in .github/workflows/utility/validate_data.mjs:501-508 - Ensures directory name matches chain_name field 3. **RPC**: Tested in .github/workflows/tests/apis.py:98 - Tests /status endpoint for connectivity 4. **REST**: Tested in .github/workflows/tests/apis.py:100 - Tests /cosmos/base/tendermint/v1beta1/syncing endpoint 5. **Address Prefix**: Validated in .github/workflows/utility/validate_data.py:172-183 - Checks bech32_prefix against SLIP-173 6. **Base Denom**: Validated in .github/workflows/utility/validate_data.mjs:93-119 - Ensures fee/staking tokens exist in assetlist 7. **Cointype**: Validated in .github/workflows/utility/validate_data.py:186-198 - Checks slip44 against SLIP-44 registry 8. **Native Token Decimals**: Validated in .github/workflows/utility/validate_data.mjs:121-174 - Checks denom_units exponent values 9. **Mainnet/Testnet**: Schema validated in chain.schema.json:67-68 - Ensures network_type is valid enum value **⚠️ Partially Tested Fields:** 10. **GRPC**: Schema defined in chain.schema.json:348-353 but no connectivity testing 11. **Block Explorer URL**: Schema defined in chain.schema.json:375-379 but no accessibility testing **❌ Missing Tests:** 12. **EVM-RPC**: Schema supports evm-http-jsonrpc endpoints in chain.schema.json:366-371 but no validation ### New Features Added: #### 1. Enhanced Chain Validation (.github/workflows/enhanced_chain_validation.yml) - New workflow that runs comprehensive validation - Tests all 12 specified fields automatically - Provides detailed error reporting #### 2. Enhanced Validation Script (.github/workflows/utility/enhanced_validation.mjs) - Validates all chain metadata fields - Tests endpoint connectivity for RPC, REST, GRPC, and EVM-RPC - Validates token decimals and asset references - Checks block explorer accessibility - Cross-references with SLIP standards #### 3. Endpoint Health Checker (.github/workflows/utility/endpoint_health_checker.mjs) - Tests actual endpoint connectivity and response times - Supports concurrent testing with rate limiting - Provides detailed health metrics by chain and provider - Tests EVM JSON-RPC endpoints for EVM-compatible chains #### 4. Validation Report Generator (.github/workflows/utility/generate_validation_report.mjs) - Creates comprehensive markdown reports - Shows validation status for all fields - Provides performance metrics and recommendations - Links back to specific validation code locations ### Key Improvements: - **EVM-RPC Testing**: Now validates JSON-RPC endpoints for EVM-compatible chains - **Block Explorer Validation**: Tests actual accessibility of explorer URLs - **GRPC Connectivity**: Basic connectivity testing for GRPC endpoints - **Performance Metrics**: Response time monitoring and health scoring - **Comprehensive Reporting**: Detailed validation reports with actionable recommendations - **Error Categorization**: Distinguishes between errors (blocking) and warnings (advisory) The new workflows ensure all 12 specified fields are automatically validated with detailed reporting and clear paths to fix any issues found. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Added configurable error downgrading to allow specific chain IDs to have validation errors converted to warnings, enabling the workflow to proceed to Endpoint Health Checks even when certain chains have validation issues. ## Changes: - Modified enhanced_validation.mjs to support DOWNGRADE_CHAIN_IDS env var - Added helper methods addError() and addWarning() for conditional downgrading - Updated all validation methods to use the new helper methods - Added logging to show which chain IDs have error downgrading enabled - Updated workflow YAML to include DOWNGRADE_CHAIN_IDS environment variable 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a comprehensive automated validation system for all chain metadata fields in the Chain Registry. The new system ensures data quality and consistency across all chains by validating 12 critical fields automatically.
Key Features
🔍 Complete Field Coverage
🚀 New Workflows & Scripts
1. Enhanced Chain Validation Workflow
.github/workflows/enhanced_chain_validation.yml2. Core Validation Engine
.github/workflows/utility/enhanced_validation.mjs3. Endpoint Health Checker
.github/workflows/utility/endpoint_health_checker.mjs4. Validation Report Generator
.github/workflows/utility/generate_validation_report.mjsCurrent vs Enhanced Validation
✅ Previously Validated
🆕 Newly Added
Benefits
🛡️ Data Quality
📊 Monitoring & Insights
🔧 Developer Experience
Testing
The validation system has been designed to:
Usage
The enhanced validation runs automatically on all PRs and can be triggered manually via workflow dispatch. Reports are generated in both human-readable markdown and machine-parseable JSON formats.
Test Plan
🤖 This PR enhances the Chain Registry's data quality assurance by providing comprehensive, automated validation of all critical chain metadata fields.