Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INVALID_FILE_HANDLE is incorrect in 64bit Windows #13

Closed
cosmo0920 opened this issue Jun 14, 2016 · 4 comments
Closed

INVALID_FILE_HANDLE is incorrect in 64bit Windows #13

cosmo0920 opened this issue Jun 14, 2016 · 4 comments

Comments

@cosmo0920
Copy link
Owner

See: fluent/fluentd#920 (comment)
@phasis68
Copy link

Here is a possible patch

INVALID_FILE_HANDLE = (1 << ['a'].pack('p').length*8) - 1

cosmo0920 added a commit that referenced this issue Jun 15, 2016
@cosmo0920
Use 64bit adopted constant
3a86f09 
Based on #13 (comment) patch.
@cosmo0920
Copy link
Owner Author

How about this patch? (Also included fixing test) 3a86f09

@djberg96
Copy link
Collaborator

['a'].pack('P').length > 4 ? "64Bit" : "32Bit"

cosmo0920 added a commit that referenced this issue Jun 20, 2016
@cosmo0920
Use 64bit adopted constant
debaba6 
Based on
#13 (comment)
and
#13 (comment)
patches.
@cosmo0920 cosmo0920 mentioned this issue Jun 20, 2016
Merged
@djberg96
Copy link
Collaborator

Looking at my win32-eventlog code you can check for JRuby like so:

RUBY_PLATFORM == 'java' && ENV_JAVA['sun.arch.data.model'] == '64'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phasis68 @djberg96 @cosmo0920