-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Ruby 3.1 UCRT binary #13
Conversation
edbb42b
to
88d139d
Compare
Oops, CI (AppVeyor) failed on Ruby 3.1... |
RubyInstaller has migrate from msvcrt.dll to ucrt.dll: https://rubyinstaller.org/2021/12/31/rubyinstaller-3.1.0-1-released.html So that symbols should be loaded from later one. Althouth I considered introducing a new constant like `UCRT_DLL`, this commit still using `MSVCRT_DLL` even if Ruby is run on ucrt.dll to keep backward compatibility. I think replacing `MSVCRT_DLL` with `UCRT_DLL` is almost meaningless, they won't used at same time. Signed-off-by: Takuro Ashie <[email protected]>
88d139d
to
2f401b9
Compare
Succeeded on GitHub Actions: What's wrong? |
Hmm, it tried to build win32-api and failed on Ruby-3.1. |
I tried to use So, we might have to keep AppVeyor's CI task entries from Ruby 2.0 to Ruby 3.0. |
I succeeded to build it on x86_64 but not yet on x86: |
And drop Ruby 3.1 for x86, it's too hard to install current win32-api due to unexpected univeral binary. In addition, probably no one uses Ruby 3.1 for x86 recent days... Signed-off-by: Takuro Ashie <[email protected]>
In my thoughts, we can drop Ruby 3.1 x86 from CI target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks attractive for me.
Thanks! |
RubyInstaller has migrate from msvcrt.dll to ucrt.dll:
https://rubyinstaller.org/2021/12/31/rubyinstaller-3.1.0-1-released.html
So that symbols should be loaded from later one.
Althouth I considered introducing a new constant like
UCRT_DLL
, thiscommit still using
MSVCRT_DLL
even if Ruby is run on ucrt.dll to keepbackward compatibility. I think replacing
MSVCRT_DLL
withUCRT_DLL
is almost meaningless, they won't used at same time.
Signed-off-by: Takuro Ashie [email protected]