Add API to set Crypto Provider #107
Conversation
| if (cnSign.ContainsKey("countersign0")) { | ||
| AddCounterSignature0(hSignObj, cnSigners.get("countersign0")); | ||
| AddCounterSignature0(hSignObj, cnSign.get("countersign0")); |
There was a problem hiding this comment.
I'm definitely not sure, but it looks to me like this should be the other way around: that the if condition should change to cnSigners instead, because there's already an if statement like this for cnSign on line 1217 above.
There was a problem hiding this comment.
Yeah, probably, but it doesn't change anything in the tests.
There was a problem hiding this comment.
Looks like this was changed in 425c5df in the end?
There was a problem hiding this comment.
I did change it, because it seems logical to me.
src/main/java/COSE/OneKey.java
Outdated
| * @throws CoseException | ||
| */ | ||
| static public OneKey generateKey(AlgorithmID algorithm, String parameters) throws CoseException { | ||
| return generateKey(algorithm, null, null); |
There was a problem hiding this comment.
Looks like this should be generateKey(algorithm, parameters, null)?
emlun
left a comment
emlun
left a comment
There was a problem hiding this comment.
I'm not sure why I was requested to review, but this seems fine to me. I'm not a maintainer of the project, though, and I don't know how the project is governed.
2 participants
Adds an API to explicitely set a Java Crypto Provider to use for all crypto operations in the library.