Skip to content

Commit

Permalink
Don't set timeout in go_test_e2e (knative#172)
Browse files Browse the repository at this point in the history
Let the caller decide. Also clarify that arguments can be flags for go test (as long as they come first).
  • Loading branch information
adrcunha authored and knative-prow-robot committed Oct 10, 2018
1 parent d55d943 commit f04cd6e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ function fail_test() {
}

# Run the given E2E tests (must be tagged as such).
# Parameters: $1..$n - directories containing the tests to run.
# Parameters: $1..$n - any go test flags, then directories containing the tests to run.
function go_test_e2e() {
local options=""
(( EMIT_METRICS )) && options="-emitmetrics"
report_go_test -v -tags=e2e -count=1 -timeout=20m $@ ${options}
report_go_test -v -tags=e2e -count=1 $@ ${options}
}

# Download the k8s binaries required by kubetest.
Expand Down

0 comments on commit f04cd6e

Please sign in to comment.