shutdown genserver without raising exception #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the connection is closed, we don't want to wait another 30s for the process to shut down. Otherwise there might be no viable adapter in the pool for 30s.
mruoss
force-pushed
the
stop-genserver-without-raising
branch
from
e8ec55b
to
48030c6
Compare
elliottneilclark
approved these changes
Aug 14, 2023
|
|
||
| @spec shutdown_if_closed(t()) :: {:noreply, t()} | {:stop, {:shutdown, :closed}, t()} | ||
| defp shutdown_if_closed(state) do | ||
| if Mint.HTTP.open?(state.conn) or any_non_empty_buffers?(state) do |
There was a problem hiding this comment.
It seems like this condition is repeated above. Would it be worth putting this into a function? Then you can also explain why the server is not shutdown even if mint has closed the connection, but there are buffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an adapter needs to be terminated, we should pass a reason that doesn't treat the termination like a crash of the process and therefore doesn't raise an exception.
refs #268
Requirements for all pull requests