Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github workflow with CY tests #1596

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

kelanik8
Copy link
Contributor

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

on:
push:
branches:
- 2023.9.x-feature-e2e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to main branch

GOFLAGS: -mod=readonly

NODE_VERSION: 16
CORTEZA_VERSION: 2023.9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this?

# - { port: 8087, name: privacy }
runs-on: ubuntu-20.04
steps:
- name: Setup tmate session
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove, this was for debugging purposes only

.github/workflows/test-e2e.yml Show resolved Hide resolved
with:
path: corteza
token: ${{ secrets.GITHUB_TOKEN }}
ref: 2023.9.x-feature-e2e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you do not need to checkout this repo as you are already in it, remove this step, but check if the folders are ok

- name: Wait for postgres healthcheck
run: timeout 180s sh -c 'until docker ps | grep corteza_postgres_1 | grep -q healthy; do echo "Waiting for container to be healthy..."; sleep 1; done'

- name: Wait for "${{ matrix.client.name }}" healthcheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the "

CLIENT_PORT: ${{ matrix.client.port }}
working-directory: corteza-e2e-cypress
run: |
docker ps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove, this is debugging statement

- "${PWD}:/corteza"
working_dir: /corteza
environment:
BUILD_VERSION: 2023.3.6-3-g251c05abf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this? if yes, why is it fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a requirement in vue.config-builder.js in each of the clients

@@ -0,0 +1,60 @@
version: "3.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be on the root of the repo, as it is github-related only.
Copy it to some other location (.github/workflows/assets/docker-compose.yaml maybe?) and use it in the github actions either directly (docker-compose -f ) or copy before use.

working_dir: /corteza/server
environment:
- DB_DSN=postgres://corteza:root@localhost:5432/corteza_cy_test?sslmode=disable
# - GIN_ARG_LADDR=0.0.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@kelanik8 kelanik8 force-pushed the 2023.9.x-feature-e2e branch 8 times, most recently from a8a43cb to cb53148 Compare January 4, 2024 13:16
yarn install && \
yarn serve --port ${CLIENT_PORT}"

docker logs ${CLIENT_NAME}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@kelanik8 kelanik8 force-pushed the 2023.9.x-feature-e2e branch from cb53148 to 8da083e Compare January 4, 2024 14:30
@kelanik8 kelanik8 merged commit 8da083e into 2023.9.x Jan 4, 2024
1 check passed
@kelanik8 kelanik8 deleted the 2023.9.x-feature-e2e branch January 4, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants