-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github workflow with CY tests #1596
Conversation
e19e4ea
to
a332766
Compare
.github/workflows/test-e2e.yml
Outdated
on: | ||
push: | ||
branches: | ||
- 2023.9.x-feature-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to main branch
.github/workflows/test-e2e.yml
Outdated
GOFLAGS: -mod=readonly | ||
|
||
NODE_VERSION: 16 | ||
CORTEZA_VERSION: 2023.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this?
.github/workflows/test-e2e.yml
Outdated
# - { port: 8087, name: privacy } | ||
runs-on: ubuntu-20.04 | ||
steps: | ||
- name: Setup tmate session |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove, this was for debugging purposes only
.github/workflows/test-e2e.yml
Outdated
with: | ||
path: corteza | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
ref: 2023.9.x-feature-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do not need to checkout this repo as you are already in it, remove this step, but check if the folders are ok
.github/workflows/test-e2e.yml
Outdated
- name: Wait for postgres healthcheck | ||
run: timeout 180s sh -c 'until docker ps | grep corteza_postgres_1 | grep -q healthy; do echo "Waiting for container to be healthy..."; sleep 1; done' | ||
|
||
- name: Wait for "${{ matrix.client.name }}" healthcheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the "
.github/workflows/test-e2e.yml
Outdated
CLIENT_PORT: ${{ matrix.client.port }} | ||
working-directory: corteza-e2e-cypress | ||
run: | | ||
docker ps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove, this is debugging statement
docker-compose.yaml
Outdated
- "${PWD}:/corteza" | ||
working_dir: /corteza | ||
environment: | ||
BUILD_VERSION: 2023.3.6-3-g251c05abf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this? if yes, why is it fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a requirement in vue.config-builder.js
in each of the clients
docker-compose.yaml
Outdated
@@ -0,0 +1,60 @@ | |||
version: "3.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be on the root of the repo, as it is github-related only.
Copy it to some other location (.github/workflows/assets/docker-compose.yaml
maybe?) and use it in the github actions either directly (docker-compose -f
) or copy before use.
docker-compose.yaml
Outdated
working_dir: /corteza/server | ||
environment: | ||
- DB_DSN=postgres://corteza:root@localhost:5432/corteza_cy_test?sslmode=disable | ||
# - GIN_ARG_LADDR=0.0.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
a8a43cb
to
cb53148
Compare
.github/workflows/test-e2e.yml
Outdated
yarn install && \ | ||
yarn serve --port ${CLIENT_PORT}" | ||
|
||
docker logs ${CLIENT_NAME} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
cb53148
to
8da083e
Compare
The following changes are implemented
TODO: Summary
Changes in the user interface:
TODO: Add screenshots, recordings or remove this section
Checklist when submitting a final (!draft) PR