Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform on delete button component to c-input-confirm #1519

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Transform on delete button component to c-input-confirm #1519

merged 1 commit into from
Nov 29, 2023

Conversation

kelanik8
Copy link
Contributor

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@kelanik8 kelanik8 requested a review from Fajfa November 10, 2023 17:06
@kelanik8 kelanik8 linked an issue Nov 10, 2023 that may be closed by this pull request
Make sure all delete buttons use c-input-confirm #1463
Closed
Fajfa
Fajfa requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@Fajfa Fajfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things to removed and some minor changes

client/web/admin/src/components/Apigw/CFilterParams.vue Outdated Show resolved Hide resolved
client/web/admin/src/components/Settings/UI/CUITopbarSettings.vue Outdated Show resolved Hide resolved
client/web/admin/src/components/Settings/UI/CUITopbarSettings.vue Outdated Show resolved Hide resolved
client/web/admin/src/components/User/CUserEditorExternalAuthProviders.vue Outdated Show resolved Hide resolved
client/web/admin/src/components/User/CUserEditorExternalAuthProviders.vue Show resolved Hide resolved
client/web/workflow/src/components/Configurator/Trigger.vue Show resolved Hide resolved
client/web/workflow/src/components/Configurator/Trigger.vue Outdated Show resolved Hide resolved
client/web/workflow/src/components/Configurator/Trigger.vue Outdated Show resolved Hide resolved
client/web/workflow/src/components/ExpressionTable.vue Outdated Show resolved Hide resolved
client/web/workflow/src/components/ExpressionTable.vue Outdated Show resolved Hide resolved
@kelanik8 kelanik8 force-pushed the 2023.9.x-feat-make-delete-buttons-c-input branch from 5e4ff25 to d41f6c8 Compare November 29, 2023 12:23
@kelanik8 kelanik8 force-pushed the 2023.9.x-feat-make-delete-buttons-c-input branch from d41f6c8 to a26303c Compare November 29, 2023 12:24
@kelanik8 kelanik8 merged commit a26303c into 2023.9.x Nov 29, 2023
1 check passed
@kelanik8 kelanik8 deleted the 2023.9.x-feat-make-delete-buttons-c-input branch November 29, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fajfa Fajfa Fajfa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure all delete buttons use c-input-confirm
2 participants
@kelanik8 @Fajfa