Skip to content

Prevent OOMs in the chunk store. #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 12, 2018
Merged

Prevent OOMs in the chunk store. #873

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e42d765
Prevent OOM in the chunk store.
tomwilkie Jul 10, 2018
aef2e91
Review feedback: Use simple Less function for chunks in test.
tomwilkie Jul 10, 2018
445d006
Review feedback: Intersect chunkIDs as we receive them.
tomwilkie Jul 10, 2018
1557226
Review feedback: unify logging and tracing in the chunk store.
tomwilkie Jul 10, 2018
16e1167
Review feedback: remove debug logging from tests.
tomwilkie Jul 10, 2018
b207ccc
Review feedback: explain spanLogger.
tomwilkie Jul 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 0 additions & 128 deletions pkg/chunk/by_key.go
View file
Open in desktop

This file was deleted.

131 changes: 0 additions & 131 deletions pkg/chunk/by_key_test.go
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions pkg/chunk/chunk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,11 @@ func (c *Chunk) Decode(decodeContext *DecodeContext, input []byte) error {
return c.Data.UnmarshalFromBuf(remainingData[:int(dataLen)])
}

func equalByKey(a, b Chunk) bool {
return a.UserID == b.UserID && a.Fingerprint == b.Fingerprint &&
a.From == b.From && a.Through == b.Through && a.Checksum == b.Checksum
}

func chunksToMatrix(ctx context.Context, chunks []Chunk, from, through model.Time) (model.Matrix, error) {
sp, ctx := ot.StartSpanFromContext(ctx, "chunksToMatrix")
defer sp.Finish()
Expand Down
Loading