Skip to content

Conversation

@yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jun 13, 2025

What this PR does:

This change is similar to #6759.

It allows parquet converter shard size to be configured to > 0 < 1 so that we use a percentage of total number of parquet converter instances in the ring.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: yeya24 <[email protected]>
Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!! :D

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 17, 2025
@alanprot alanprot merged commit 826e32a into cortexproject:master Jun 17, 2025
31 of 32 checks passed
bogdan-st pushed a commit to bogdan-st/cortex that referenced this pull request Jun 30, 2025
* add dynamic shard size for parquet converter

Signed-off-by: yeya24 <[email protected]>

* update changelog

Signed-off-by: yeya24 <[email protected]>

---------

Signed-off-by: yeya24 <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Co-authored-by: Alan Protasio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants