Skip to content

Conversation

alexqyle
Copy link
Contributor

What this PR does:

Error message changed in this commit fd1dca4#diff-4d46760513b4f0a55e4cebb89e6a055859204f00ca50220cd42b5191b018b152R1039. This caused compactor tests to fail because ignored message did not match anymore.

Which issue(s) this PR fixes:

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. How we didn't find this when merging the previous PR

Copy link
Contributor

@danielblando danielblando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@alexqyle
Copy link
Contributor Author

Nice catch. How we didn't find this when merging the previous PR

It is timing issue when running test. The problematic log was logged the last. If it got logged in logs object after fetching all logs inside ElementsMatch assertion, the test would pass. Otherwise, test would fail.

@alanprot
Copy link
Member

We REALLY need to stop merging PRs with the test not green!

IDK how to block this on GH though! =/

@alanprot alanprot enabled auto-merge (squash) June 12, 2025 22:35
@alanprot
Copy link
Member

Ok.. i think now we can only merge is is all green!

@alanprot alanprot merged commit be90c4a into cortexproject:master Jun 12, 2025
31 of 32 checks passed
@alexqyle alexqyle deleted the fix-compactor-test branch June 13, 2025 00:11
@SungJin1212
Copy link
Member

@alexqyle
Thanks for catching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants