Skip to content

Fix race condition in active user #6773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Fix race condition in active user #6773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
* [BUGFIX] Query Frontend: Fix query frontend per `user` metrics clean up. #6698
* [BUGFIX] Add `__markers__` tenant ID validation. #6761
* [BUGFIX] Ring: Fix nil pointer exception when token is shared. #6768
* [BUGFIX] Fix race condition in active user. #6773

## 1.19.0 2025-02-27

Expand Down
2 changes: 1 addition & 1 deletion pkg/util/active_user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ func (m *ActiveUsers) PurgeInactiveUsers(deadline int64) []string {
}

func (m *ActiveUsers) ActiveUsers(deadline int64) []string {
active := make([]string, 0, len(m.timestamps))
m.mu.RLock()
active := make([]string, 0, len(m.timestamps))
defer m.mu.RUnlock()
for userID, ts := range m.timestamps {
if ts.Load() > deadline {
Expand Down
Loading