Change error code and configuration of resource-based limiter #6771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR includes two changes:
1. Change error code of resource exhausted query rejection from 429 to 503
This ends up changing error code returned to the user from 422 to 500 (Prometheus currently has a static mapping, which I'm trying to make customizble).
The reason we want to return 5xx rather than 4xx is that nodes with resources exhausted is more of a system failure rather than user error.
2. Change configuration
I'm planning to add more features to the query protection, and make it available for all query components (query rejection is just one of many features we can implement). Thus, I wanted to change the configuration to be more flexible:
The new config will be easier to extend as we add more query protection features:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]