Skip to content

Conversation

@dankrzeminski32
Copy link
Contributor

Removes an unnecessary if/else block in ruler_test.go

Fixes #6287

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added the component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. label Mar 11, 2025
Signed-off-by: dankrzeminski32 <[email protected]>
@dankrzeminski32 dankrzeminski32 force-pushed the fix-redundant-ifelse-in-ruler-test branch from f982935 to 0743cc6 Compare March 11, 2025 02:55
@dankrzeminski32 dankrzeminski32 changed the title remove redundant if else block remove redundant if else block in ruler_test.go Mar 11, 2025
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 11, 2025
@friedrichg friedrichg merged commit 465e654 into cortexproject:master Mar 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. lgtm This PR has been approved by a maintainer size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Both branches of if-then-else are identical in pkg/ruler/ruler_test.go

2 participants