Add fallback logic to thanos promql engine #6630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
Add-thanos-engine-fallback
branch
from
dc78802 to
8af8936
Compare
SungJin1212
force-pushed
the
Add-thanos-engine-fallback
branch
from
8af8936 to
bbc0cc1
Compare
yeya24
requested changes
Mar 5, 2025
yeya24
reviewed
Mar 5, 2025
| if qf.thanosEngine != nil { | ||
| res, err := qf.thanosEngine.MakeInstantQuery(ctx, q, fromPromQLOpts(opts), qs, ts) | ||
| if err != nil { | ||
| if engine.IsUnimplemented(err) { |
There was a problem hiding this comment.
Can we add a counter metric for number of fallbacks because new engine doesn't support it?
Similar to
https://github.com/thanos-io/promql-engine/pull/518/files#diff-2e6c4934f63ff9b712c2c346b33036af4724adf70b0801fff9b74f71b37fcd89L180
There was a problem hiding this comment.
I add a metric and update the pr.
SungJin1212
force-pushed
the
Add-thanos-engine-fallback
branch
2 times, most recently
from
1dcc56d to
c37ece7
Compare
yeya24
reviewed
Mar 6, 2025
SungJin1212
force-pushed
the
Add-thanos-engine-fallback
branch
from
c37ece7 to
3f2a618
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Add-thanos-engine-fallback
branch
from
3f2a618 to
8762531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fallback logic to the thanos-promql engine.
FYI. The current version of the thanos-promql supports fallback logic, so there is no user impact.
Which issue(s) this PR fixes:
Fixes #6624
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]