Skip to content

Conversation

@yeya24
Copy link
Contributor

@yeya24 yeya24 commented Feb 28, 2025

What this PR does:

Upgrade thanos promql engine version to pull thanos-io/promql-engine#519 which fixes a performance regression.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added go Pull requests that update Go code type/performance labels Feb 28, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2025
@yeya24
Copy link
Contributor Author

yeya24 commented Mar 1, 2025

    query_fuzz_test.go:1642: case 380 results mismatch.
        instant query: stddev by (__name__, series) (
          quantile without (job) (
            time(),
            -sort_desc({__name__="test_series_b",status_code!="400"} offset -2m9s)
          )
        )
        res1: {series="3"} => NaN @[1740777565.629]
        {series="5"} => NaN @[1740777565.629]
        res2: {series="3"} => 0 @[1740777565.629]
        {series="5"} => 0 @[1740777565.629]

@yeya24 yeya24 merged commit 684c90a into cortexproject:master Mar 1, 2025
16 of 17 checks passed
@yeya24 yeya24 deleted the upgrade-promql-engine-fix-regression branch March 1, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code lgtm This PR has been approved by a maintainer size/XS type/performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants