Removing fingerprint calculator from the lock on the GetSeries API #4765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinlin123
approved these changes
Jun 28, 2022
|
Shall we post a benchmark result here? |
alvinlin123
approved these changes
Jun 28, 2022
alvinlin123
pushed a commit
that referenced
this pull request
Jul 6, 2022
…4765) * Removing fingerprint calculator from the lock on the GetSeries API * Add test to prove order does not matter on QueryLimiter,AddSeries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Removes the series fingerprint calculation from the locked code.
We are sorting the series labels and calculating the hash to get the fingerprint. This code can be a little heavy and there is no reason to be locked.
This changed improved the latency on retrieving 1M series from ~37 seconds to ~29 seconds.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]